From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 2b97e83cc1 2/2: Fix off-by-one file size formatting in ls-lisp Date: Sun, 13 Feb 2022 14:55:09 +0200 Message-ID: <83ee47q636.fsf@gnu.org> References: <164464970577.18616.16858189491672331595@vcs2.savannah.gnu.org> <20220212070826.4B772C00895@vcs2.savannah.gnu.org> <83y22frjpy.fsf@gnu.org> <83tud3ri2n.fsf@gnu.org> <83r187rhd8.fsf@gnu.org> <83pmnrqo5m.fsf@gnu.org> <87h793yxtm.fsf@gnus.org> <83h793q7r5.fsf@gnu.org> <874k53uen1.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11440"; mail-complaints-to="usenet@ciao.gmane.io" Cc: salutis@me.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Feb 13 13:57:24 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJERO-0002mc-QS for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Feb 2022 13:57:22 +0100 Original-Received: from localhost ([::1]:42170 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nJERN-0008D3-9J for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Feb 2022 07:57:21 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34780) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJEPO-0007Ob-GH for emacs-devel@gnu.org; Sun, 13 Feb 2022 07:55:18 -0500 Original-Received: from [2001:470:142:3::e] (port=34816 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJEPN-0004r1-5K; Sun, 13 Feb 2022 07:55:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=mfRxNTfG165hzBMuw1358nwN3vs7fQn8/wXapBqqY94=; b=MKFbxWvAv0OhpCJ2+IP+ 60RtimKCXNlK6Ufnwzk2siuNMXb0fOJ8fsrhYQL4nIRQbtyBziAYkQPEaGN1dHR5X4MbT15x8xpat IMPlgsazYZ9+px+AMTL4mMddK+Co7uCtwU/3/ZlKjfe4E7tBKWn2n/YzMU6xKXyzG1johRTkm/O6I A1nC+5VR4Kjn7lFkzX0ZXS2Mr+O1p4H8nyp/euKgbO9T0QOIcBX+i9CilpJKF7Op6qRRnIra9H5Ks GeN0mtTz9/dWwuip74t040Oy9llIcuZ//zeA4Qbn/OE0BEkygXrXNKd/RllXgna0EgamQtdeTBR1e uK5/BqA1KkRCIQ==; Original-Received: from [87.69.77.57] (port=1934 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJEPJ-0005zm-DJ; Sun, 13 Feb 2022 07:55:16 -0500 In-Reply-To: <874k53uen1.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 13 Feb 2022 13:36:50 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286209 Archived-At: > From: Lars Ingebrigtsen > Cc: Rudolf Adamkovič , > monnier@iro.umontreal.ca, > emacs-devel@gnu.org > Date: Sun, 13 Feb 2022 13:36:50 +0100 > > Like I said in an earlier post, my test file is 1029204 bytes. > > (file-size-human-readable 1029204) > -> "1005.1k" Ah, okay. So you want to lose accuracy in these cases and just throw away the fractional part? Why? I'm quite sure "ls -lh" still does that, albeit perhaps not with this specific size.