From: Eli Zaretskii <eliz@gnu.org>
To: Yasushi SHOJI <yasushi.shoji@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Location of mouse click
Date: Fri, 15 Apr 2022 09:23:31 +0300 [thread overview]
Message-ID: <83ee1y3lwc.fsf@gnu.org> (raw)
In-Reply-To: <CAELBRWKM8kTOhLjLngRJGAGYOq72LGFJhwwQNVzBQJhT5zJLQg@mail.gmail.com> (message from Yasushi SHOJI on Fri, 15 Apr 2022 14:11:23 +0900)
> From: Yasushi SHOJI <yasushi.shoji@gmail.com>
> Date: Fri, 15 Apr 2022 14:11:23 +0900
> Cc: emacs-devel@gnu.org
>
> On Fri, Apr 15, 2022 at 2:43 AM Eli Zaretskii <eliz@gnu.org> wrote:
> > > > 0. emacs -Q
> > > > 1. open a.txt
> > > > 2. (toggle-truncate-lines)
> > > > 3. goto the end of the last line
> > > > 4. make the frame narrow so that "あ"s are not shown
> > > > 5. click on the last word "dog"
> > > >
> > > > But, this assumes that Japanese and ASCII chars have different heights.
> > > >
> > > > > If it is important to click the mouse at specific
> > > >
> > > > You can click anywhere on the last line.
> > >
> > > Thanks, I see the problem and will look into it.
> >
> > I hope I've now fixed this on the master branch.
>
> Thank you, Eli. The change, 67e7870a, works perfectly.
Thanks for testing, and for a clear test case.
> Would you mind backporting to 28? I've tested the change
> by cherry picking on 28, and it works without a glitch.
You are free to use it in your Emacs 28, but I don't consider it safe
enough to have this change in Emacs 28.2 for the general consumption.
As simple and innocent as the change may look, it was done in a very
low-level subroutine, which is used all over the place in display
code. I cannot predict what issues it could cause elsewhere, which
would require followup changes to unbreak. OTOH, the problem you
described exists since Emacs 25.1, so it cannot be too annoying, or we
would have heard about it sooner; thus, fixing it is not an urgent
enough need, and doesn't outweigh the potential dangers of
destabilizing the release branch. Sorry.
next prev parent reply other threads:[~2022-04-15 6:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 12:44 Location of mouse click Yasushi SHOJI
2022-04-13 13:30 ` Eli Zaretskii
2022-04-13 14:51 ` Yasushi SHOJI
2022-04-13 15:58 ` Eli Zaretskii
2022-04-14 17:43 ` Eli Zaretskii
2022-04-15 5:11 ` Yasushi SHOJI
2022-04-15 6:23 ` Eli Zaretskii [this message]
2022-04-15 11:58 ` Yasushi SHOJI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ee1y3lwc.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=yasushi.shoji@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).