From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 5743b74d4b 1/2: Improve mouse dragging Date: Thu, 12 May 2022 16:51:07 +0300 Message-ID: <83ee0yq2pg.fsf@gnu.org> References: <83sfpfp5p1.fsf@gnu.org> <87sfpfx8j8.fsf@yahoo.com> <83ilqaq5o9.fsf@gnu.org> <87fsleykdp.fsf@yahoo.com> <83h75uq4id.fsf@gnu.org> <87bkw2yjeg.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22648"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 12 15:52:16 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1np9Em-0005lx-7X for ged-emacs-devel@m.gmane-mx.org; Thu, 12 May 2022 15:52:16 +0200 Original-Received: from localhost ([::1]:52996 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1np9Ek-0004jm-RN for ged-emacs-devel@m.gmane-mx.org; Thu, 12 May 2022 09:52:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40736) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1np9De-00041b-0T for emacs-devel@gnu.org; Thu, 12 May 2022 09:51:06 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36602) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1np9Dd-0003QG-Jq; Thu, 12 May 2022 09:51:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=lTFDh7NQ1hsAuvItGIsrWqGYLrh/EJTfTwHyzMLL9f0=; b=mFQ7jYe254SN AmAgxpYnux+ZNgYOAZm9KzKLa1yweV1oKYXxbqPTby8mJvp95Rz+hY1/fY6dnQCP23SNt+rxK/ev5 6X3jZhVsbLQSjA5q5EziA5LKNcCgq46ZIqBOL9HHCc7hAo73jl9nyhJJwgSkxs/l1vO0C0m0wbhxz fXdYgIY5ReP7J1W+PX49cL5Mj/AdoqljYe7YzoUe6Pf1WG0Y7nckyxvTInwHNF7MrP7eig2MHCI8s RBZXLh+zGQD/grmg3RGG92AbdR8kYYjLKUSBhcP3HcNtiLgCtyosHeuNWYHUDk3Hn0/ywHn2imKxO 3QBItXNuh/2CHt89bNneUA==; Original-Received: from [87.69.77.57] (port=3818 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1np9Db-00076Q-Cm; Thu, 12 May 2022 09:51:04 -0400 In-Reply-To: <87bkw2yjeg.fsf@yahoo.com> (message from Po Lu on Thu, 12 May 2022 21:23:19 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289689 Archived-At: > From: Po Lu > Cc: emacs-devel@gnu.org > Date: Thu, 12 May 2022 21:23:19 +0800 > > That code would add text properties to the `text' argument to > `x-show-tip', which is bad, because `mouse-drag-and-drop-region' > reinserts the string passed as `text' into the buffer the mouse was > dropped on top of afterwards, which causes the inserted text to be > propertized with the wrong face. I see no argument named 'text' in that function, so I'm not sure I understand what you are alluding to. In any case, if the problem is that some text was modified that later has to be inserted, a simple copy-sequence should have solved that, no?