unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: akrl@sdf.org, emacs-devel@gnu.org, larsi@gnus.org
Subject: Re: master 05d240997a 2/2: Add native-compile-prune-cache command
Date: Fri, 22 Jul 2022 21:03:44 +0300	[thread overview]
Message-ID: <83edydja7z.fsf@gnu.org> (raw)
In-Reply-To: <87lesl9k1n.fsf@gmail.com> (message from Robert Pluim on Fri, 22 Jul 2022 18:41:40 +0200)

> From: Robert Pluim <rpluim@gmail.com>
> Cc: akrl@sdf.org,  emacs-devel@gnu.org,  larsi@gnus.org
> Date: Fri, 22 Jul 2022 18:41:40 +0200
> 
> >>>>> On Fri, 22 Jul 2022 19:18:19 +0300, Eli Zaretskii <eliz@gnu.org> said:
> 
>     >> From: Robert Pluim <rpluim@gmail.com>
>     >> Cc: akrl@sdf.org,  emacs-devel@gnu.org,  larsi@gnus.org
>     >> Date: Fri, 22 Jul 2022 17:46:07 +0200
>     >> 
>     >> >>>>> On Fri, 22 Jul 2022 18:41:09 +0300, Eli Zaretskii <eliz@gnu.org> said:
>     >> 
>     >> >> From: Robert Pluim <rpluim@gmail.com>
>     >> >> Cc: emacs-devel@gnu.org,  Lars Ingebrigtsen <larsi@gnus.org>
>     >> >> Date: Fri, 22 Jul 2022 17:36:16 +0200
>     >> >> 
>     >> >> Something like this (untested) in `normal-top-level'?
>     >> >> 
>     >> >> (unless (featurep 'native-compile)
>     >> >> (with-eval-after-load 'comp
>     >> >> (display-warning 'comp "This emacs does not support native compilation" :warning)))
>     >> 
>     Eli> Why do we need this, again?
>     >> 
>     >> I had comp.el loaded in my non-native compile capable Emacs, and tried
>     >> to run `native-compile-prune-cacheʼ, which gave me an error. Either we
>     >> accept that I did something that shouldnʼt be done, or we try to warn
>     >> people that they shouldnʼt do it (or on the gripping hand we add code
>     >> to check 'native-compile to a bunch of stuff in comp.el).
> 
>     Eli> What would be the reason to load comp.el in such a session?
> 
> User error. Some people might write (require ʼcomp) in their
> .emacs. Iʼm sure we can come up with lots of scenarios.

If we want to handle user error of loading the file, then placing the
code you suggested in comp.el itself would be TRT, I think.  Not in
startup.el.



  reply	other threads:[~2022-07-22 18:03 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <165675959499.8421.12451308740112322312@vcs2.savannah.gnu.org>
     [not found] ` <20220702105957.4B7EFC016B5@vcs2.savannah.gnu.org>
2022-07-22  8:51   ` master 05d240997a 2/2: Add native-compile-prune-cache command Robert Pluim
2022-07-22 12:29     ` Stefan Monnier
2022-07-22 12:45     ` Andrea Corallo
2022-07-22 13:01       ` Robert Pluim
2022-07-22 13:51         ` Andrea Corallo
2022-07-22 14:15           ` Robert Pluim
2022-07-22 15:14             ` Andrea Corallo
2022-07-22 15:36               ` Robert Pluim
2022-07-22 15:41                 ` Eli Zaretskii
2022-07-22 15:46                   ` Robert Pluim
2022-07-22 16:18                     ` Eli Zaretskii
2022-07-22 16:41                       ` Robert Pluim
2022-07-22 18:03                         ` Eli Zaretskii [this message]
2022-07-22 16:42                       ` Andreas Schwab
2022-07-22 18:04                         ` Eli Zaretskii
2022-07-22 19:49                     ` Stefan Monnier
2022-07-22 16:50                 ` Andrea Corallo
2022-07-22 18:05                   ` Eli Zaretskii
2022-07-22 18:24                     ` Andrea Corallo
2022-07-22 18:59                       ` Eli Zaretskii
2022-07-22 23:20                         ` Andrea Corallo
2022-07-22 23:41                           ` Stefan Monnier
2022-07-24 17:55                             ` Andrea Corallo
2022-07-22 19:47             ` Stefan Monnier
2022-07-22 19:46       ` Stefan Monnier
2022-07-22 23:17         ` Andrea Corallo
2022-07-22 23:38           ` Stefan Monnier
2022-07-23  6:43             ` Eli Zaretskii
2022-07-23 13:47               ` Stefan Monnier
2022-07-22 19:56     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83edydja7z.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=akrl@sdf.org \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).