From: Eli Zaretskii <eliz@gnu.org>
To: Theodor Thornhill <theo@thornhill.no>
Cc: emacs-devel@gnu.org, casouri@gmail.com, monnier@iro.umontreal.ca
Subject: Re: CC Mode -> Tree sitter challenge
Date: Sat, 05 Nov 2022 11:13:52 +0200 [thread overview]
Message-ID: <83eduh4vcf.fsf@gnu.org> (raw)
In-Reply-To: <87v8nu1mt1.fsf@thornhill.no> (message from Theodor Thornhill on Fri, 04 Nov 2022 21:34:18 +0100)
> From: Theodor Thornhill <theo@thornhill.no>
> Cc: Eli Zaretskii <eliz@gnu.org>, casouri@gmail.com, Stefan Monnier
> <monnier@iro.umontreal.ca>
> Date: Fri, 04 Nov 2022 21:34:18 +0100
>
>
> Hi Eli and others!
>
> So you challenged me to add some more modes that are supported in CC
> Mode, but not using CC Mode. I finally got some free hours, so here's
> my first follow-up to your "show me the code".
>
> In this repo[0] you will find support for the following modes:
>
> - javascript (this is already in tree-sitter branch - but adding
> without cc mode here)
> - c
> - c++
> - java
> - css
> - JSON
> - TypeScript (left out, as it is in tree-sitter branch already)
Thanks.
> 2. I've focused mostly on indentation and font locking. Indentation is
> using xdisp code style and the gnu style in general.
We should ideally support all the indentation styles supported by CC
Mode.
> When scrolling through xdisp with this variant of C support it is
> noticeably faster on my system. However, I'd like some guidance on how
> to provide some benchmarks to prove my guess.
We usually use something like the below:
(defun scroll-up-benchmark ()
(interactive)
(let ((oldgc gcs-done)
(oldtime (float-time)))
(condition-case nil (while t (scroll-up) (redisplay))
(error (message "GCs: %d Elapsed time: %f seconds"
(- gcs-done oldgc) (- (float-time) oldtime))))))
(defun scroll-up-by-40-benchmark ()
(interactive)
(let ((oldgc gcs-done)
(oldtime (float-time)))
(condition-case nil (while t (scroll-up 40) (redisplay))
(error (message "GCs: %d Elapsed time: %f seconds"
(- gcs-done oldgc) (- (float-time) oldtime))))))
The instructions are: visit xdisp.c and immediately invoke one of
these two functions; then record the time it took to scroll through
the entire file. Compare to CC Mode.
I think we also want to see the above modified to make some change to
the buffer once in a while. For example, once in 100 lines insert a
quote ", or a /* followed by */ after several lines, and see how that
affects the scroll times with both modes.
> Loading said file and immediately going to EOB is instant, but in CC
> Mode takes a little less than a second.
Timing this with benchmark-run and presenting the numbers is also
interesting.
next prev parent reply other threads:[~2022-11-05 9:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 20:34 CC Mode -> Tree sitter challenge Theodor Thornhill
2022-11-04 20:36 ` Theodor Thornhill
2022-11-04 20:38 ` Stefan Monnier
2022-11-04 20:44 ` Theodor Thornhill
2022-11-04 23:10 ` Yuan Fu
2022-11-05 7:56 ` Theodor Thornhill
2022-11-06 1:01 ` Yuan Fu
2022-11-06 5:54 ` Theodor Thornhill
2022-11-05 9:13 ` Eli Zaretskii [this message]
2022-11-05 13:12 ` Theodor Thornhill
2022-11-05 13:31 ` Eli Zaretskii
2022-11-05 13:42 ` Theodor Thornhill
2022-11-05 14:37 ` Theodor Thornhill
2022-11-05 14:55 ` Eli Zaretskii
2022-11-05 15:06 ` Theodor Thornhill
2022-11-05 15:27 ` Theodor Thornhill
2022-11-05 16:38 ` Theodor Thornhill
2022-11-05 16:43 ` Eli Zaretskii
2022-11-06 1:13 ` Yuan Fu
2022-11-06 6:04 ` Theodor Thornhill
2022-11-07 0:11 ` Yuan Fu
2022-11-07 8:05 ` Theodor Thornhill
2022-11-05 14:34 ` Stefan Monnier
2022-11-05 14:46 ` Theodor Thornhill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83eduh4vcf.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=casouri@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).