From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Added alias for removed font-lock function Date: Sat, 07 Jan 2023 10:52:49 +0200 Message-ID: <83eds6u3oe.fsf@gnu.org> References: <49cdc78c-f4f4-4300-982c-ad1909da3547@app.fastmail.com> <22714367-c1e6-4562-9af5-63ac6ff0aecb@app.fastmail.com> <6d72ba64-3c32-4957-94c8-9c1f41442878@app.fastmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31356"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: "Benson Chu" , Stefan Monnier , Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 07 09:53:04 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pE4wq-00082W-2J for ged-emacs-devel@m.gmane-mx.org; Sat, 07 Jan 2023 09:53:04 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pE4wK-0001p5-Cw; Sat, 07 Jan 2023 03:52:32 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pE4wI-0001oi-Hx for emacs-devel@gnu.org; Sat, 07 Jan 2023 03:52:30 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pE4wI-0002vn-5A; Sat, 07 Jan 2023 03:52:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=4UqqidWWZ7j5Rd5o7RTam9fvjyzJzpfTzUEySrkhisM=; b=hqwdDQdd4TB8 nfB6ypN5ZpwvEMc2WelOyhzVV4oNWtWmMHQ15TZS5JQmHbsURddiIGy5/2CqpIgwv2fOajDI3erw0 VdpYtrDNpOxjrKL0BZnY/FvkNQ/HtGAp+6bkZnG0H2sjvOayawgGdFi6WOtps9+y0gXQEnmq0HiWX tAqTP5A7QFDUcZjQR4+dpzSHDTlfXktRVEA9z9aQtuX4F87ngZBgStFF7InER+XNBw4/XqFawJceW sSAMBpHMFvV+mDO4Ko8YyC5xsYzxO5xFGqJ1Z9zWIYv0liE9RCGdil1rig/CpTYjK4nXXh+RQJGQV mATkyH4TVxtpthcTD4F/AA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pE4wH-0002Co-B8; Sat, 07 Jan 2023 03:52:29 -0500 In-Reply-To: <6d72ba64-3c32-4957-94c8-9c1f41442878@app.fastmail.com> (bensonchu457@gmail.com) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302267 Archived-At: > Date: Sat, 31 Dec 2022 22:57:34 -0600 > From: "Benson Chu" > > Er, I mean this. > > Thanks! > Benson > > On Sat, Dec 31, 2022, at 10:53 PM, Benson Chu wrote: > > Something like this? > > > > Thanks! > > Benson > > > > On Thu, Dec 22, 2022, at 8:49 AM, Stefan Monnier wrote: > >>> +(define-obsolete-function-alias 'font-lock-fontify-syntactically-region #'font-lock-default-fontify-syntactically "29.1") > >> > >> > >> Indeed, tho, could you try and fit this within 80 columns? > >> Also, I think the better replacement for the old > >> `font-lock-fontify-syntactically-region` could be > >> (funcall font-lock-fontify-syntactically-function BEG END), which by > >> default will end up calling `font-lock-default-fontify-syntactically`. > >> > >> > >> Stefan > > Attachments: > > * 0001-Added-back-renamed-function-font-lock-fontify-syntac.patch > > From 6b21f1ed56b0b196fba3a626f50464b91139db47 Mon Sep 17 00:00:00 2001 > From: Benson Chu > Date: Sat, 31 Dec 2022 19:45:43 -0600 > Subject: [PATCH] Added back renamed function > font-lock-fontify-syntactically-region > > A more accurate replacement for font-lock-fontify-syntactically-region > would be a function that funcalls the > font-lock-fontify-syntactically-function variable. That way, callers > of the function can inherit new behavior, if the value of that variable > changes. > > * lisp/font-lock.el: remove obsolete alias, added defun for Stefan, Lars, any further comments? If not, I will install this soon on the emacs-29 branch.