From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Changes in process.c Date: Thu, 08 Jul 2010 21:33:15 +0300 Message-ID: <83d3ux7ris.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1278614153 8618 80.91.229.12 (8 Jul 2010 18:35:53 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 8 Jul 2010 18:35:53 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 08 20:35:51 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OWvwt-00045t-02 for ged-emacs-devel@m.gmane.org; Thu, 08 Jul 2010 20:35:51 +0200 Original-Received: from localhost ([127.0.0.1]:49552 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OWvws-0008JL-BQ for ged-emacs-devel@m.gmane.org; Thu, 08 Jul 2010 14:35:50 -0400 Original-Received: from [140.186.70.92] (port=38261 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OWvwj-0008JG-0d for emacs-devel@gnu.org; Thu, 08 Jul 2010 14:35:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OWvwe-0007uP-Pd for emacs-devel@gnu.org; Thu, 08 Jul 2010 14:35:40 -0400 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:41295) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OWvwe-0007uC-FG for emacs-devel@gnu.org; Thu, 08 Jul 2010 14:35:36 -0400 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0L59004004WQ8N00@a-mtaout21.012.net.il> for emacs-devel@gnu.org; Thu, 08 Jul 2010 21:35:15 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([77.127.120.144]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L5900MH54YR7IC0@a-mtaout21.012.net.il> for emacs-devel@gnu.org; Thu, 08 Jul 2010 21:35:15 +0300 (IDT) X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:126917 Archived-At: People who make changes in process.c related to keyboard input and wait_reading_process_output, please remember that there are two branches in process.c, one for systems that support async subprocesses, the other for those which don't (only MS-DOS in the latter class). Making changes only in one of them is going to break something. Btw, unless there are good reasons to have the new hold-keyboard functions in process.c, I would suggest to move them to keyboard.c, since this will eliminate the need to have 2 implementations of them.