unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: t_tuneyosi@hotmail.com, emacs-devel@gnu.org
Subject: Re: linum.el: problem (bug ?) fix and improvement
Date: Thu, 12 May 2011 20:21:00 +0300	[thread overview]
Message-ID: <83d3jnhm2r.fsf@gnu.org> (raw)
In-Reply-To: <jwv4o50591y.fsf-monnier+emacs@gnu.org>

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Thu, 12 May 2011 10:58:58 -0300
> Cc: emacs-devel@gnu.org
> 
> What we'd like here is for the redisplay to ignore the margin property
> placed on invisible text.

Are you sure?  Only part of a line could be invisible, in which case
it won't be easy to explain why we drop the before-string on the
floor.  I would be uneasy to make such radical changes on behalf of a
single use case.

> This boils down to making Emacs ignore
> `before-string' properties placed at the beginning of invisible text.
> I don't think it's always right to ignore them, tho.

There's explicit code to do it the way we do now:

	  /* If there are before-strings at the start of invisible
	     text, and the text is invisible because of a text
	     property, arrange to show before-strings because 20.x did
	     it that way.  (If the text is invisible because of an
	     overlay property instead of a text property, this is
	     already handled in the overlay code.)  */
	  if (NILP (overlay)
	      && get_overlay_strings (it, it->stop_charpos))
	    {
	      handled = HANDLED_RECOMPUTE_PROPS;
	      it->stack[it->sp - 1].display_ellipsis_p = display_ellipsis_p;
	    }

Just undoing this would be regression from Emacs 20.x.



  reply	other threads:[~2011-05-12 17:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-07 14:50 linum.el: problem (bug ?) fix and improvement Toru TSUNEYOSHI
2011-05-12 13:58 ` Stefan Monnier
2011-05-12 17:21   ` Eli Zaretskii [this message]
2011-05-12 19:43     ` Stefan Monnier
2011-05-13 12:14   ` Toru TSUNEYOSHI
2011-05-13 14:15     ` Stefan Monnier
2011-05-13 15:55       ` Toru TSUNEYOSHI
2011-05-13 16:26         ` Stefan Monnier
2011-05-14  1:53           ` Toru TSUNEYOSHI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83d3jnhm2r.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=t_tuneyosi@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).