From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: /srv/bzr/emacs/trunk r109685: Rely on to declare 'environ' Date: Mon, 20 Aug 2012 05:54:56 +0300 Message-ID: <83d32mclxb.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1345431315 13327 80.91.229.3 (20 Aug 2012 02:55:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 20 Aug 2012 02:55:15 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 20 04:55:15 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T3I94-0003Jw-Do for ged-emacs-devel@m.gmane.org; Mon, 20 Aug 2012 04:55:14 +0200 Original-Received: from localhost ([::1]:53716 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3I93-0000HM-1c for ged-emacs-devel@m.gmane.org; Sun, 19 Aug 2012 22:55:13 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:50075) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3I90-0000GE-Qf for emacs-devel@gnu.org; Sun, 19 Aug 2012 22:55:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3I8z-0008NN-Tz for emacs-devel@gnu.org; Sun, 19 Aug 2012 22:55:10 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:59712) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3I8z-0008NH-ME for emacs-devel@gnu.org; Sun, 19 Aug 2012 22:55:09 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0M910010097OYB00@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Mon, 20 Aug 2012 05:54:55 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M910011Y9FJV130@a-mtaout20.012.net.il>; Mon, 20 Aug 2012 05:54:55 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:152690 Archived-At: These parts of your changes seem to be wrong, or at least under-documented in ChangeLog: the Windows build does not use lib/unistd.h. Why did you make them? === modified file 'src/callproc.c' --- a/src/callproc.c 2012-08-04 14:17:10 +0000 +++ b/src/callproc.c 2012-08-19 21:00:09 +0000 @@ -65,10 +65,6 @@ #include "nsterm.h" #endif -#ifndef USE_CRT_DLL -extern char **environ; -#endif - #ifdef HAVE_SETPGID #if !defined (USG) #undef setpgrp === modified file 'src/editfns.c' --- a/src/editfns.c 2012-08-18 06:06:39 +0000 +++ b/src/editfns.c 2012-08-19 21:00:09 +0000 @@ -58,10 +58,6 @@ #include "window.h" #include "blockinput.h" -#ifndef USE_CRT_DLL -extern char **environ; -#endif - #define TM_YEAR_BASE 1900 #ifdef WINDOWSNT === modified file 'src/emacs.c' --- a/src/emacs.c 2012-08-05 21:44:21 +0000 +++ b/src/emacs.c 2012-08-19 21:00:09 +0000 @@ -642,10 +642,6 @@ static void malloc_initialize_hook (void) { -#ifndef USE_CRT_DLL - extern char **environ; -#endif - if (initialized) { if (!malloc_using_checking) === modified file 'src/process.c' --- a/src/process.c 2012-08-18 06:06:39 +0000 +++ b/src/process.c 2012-08-19 21:00:09 +0000 @@ -1623,9 +1623,6 @@ /* Use volatile to protect variables from being clobbered by longjmp. */ volatile int forkin, forkout; volatile int pty_flag = 0; -#ifndef USE_CRT_DLL - extern char **environ; -#endif inchannel = outchannel = -1;