unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: Re: /srv/bzr/emacs/trunk r109685: Rely on <unistd.h> to declare 'environ'
Date: Mon, 20 Aug 2012 05:54:56 +0300	[thread overview]
Message-ID: <83d32mclxb.fsf@gnu.org> (raw)
In-Reply-To: <mailman.445588.1345421843.854.emacs-diffs@gnu.org>

These parts of your changes seem to be wrong, or at least
under-documented in ChangeLog: the Windows build does not use
lib/unistd.h.  Why did you make them?

  === modified file 'src/callproc.c'
  --- a/src/callproc.c	2012-08-04 14:17:10 +0000
  +++ b/src/callproc.c	2012-08-19 21:00:09 +0000
  @@ -65,10 +65,6 @@
   #include "nsterm.h"
   #endif

  -#ifndef USE_CRT_DLL
  -extern char **environ;
  -#endif
  -
   #ifdef HAVE_SETPGID
   #if !defined (USG)
   #undef setpgrp

  === modified file 'src/editfns.c'
  --- a/src/editfns.c	2012-08-18 06:06:39 +0000
  +++ b/src/editfns.c	2012-08-19 21:00:09 +0000
  @@ -58,10 +58,6 @@
   #include "window.h"
   #include "blockinput.h"

  -#ifndef USE_CRT_DLL
  -extern char **environ;
  -#endif
  -
   #define TM_YEAR_BASE 1900

   #ifdef WINDOWSNT

  === modified file 'src/emacs.c'
  --- a/src/emacs.c	2012-08-05 21:44:21 +0000
  +++ b/src/emacs.c	2012-08-19 21:00:09 +0000
  @@ -642,10 +642,6 @@
   static void
   malloc_initialize_hook (void)
   {
  -#ifndef USE_CRT_DLL
  -  extern char **environ;
  -#endif
  -
     if (initialized)
       {
	 if (!malloc_using_checking)

  === modified file 'src/process.c'
  --- a/src/process.c	2012-08-18 06:06:39 +0000
  +++ b/src/process.c	2012-08-19 21:00:09 +0000
  @@ -1623,9 +1623,6 @@
     /* Use volatile to protect variables from being clobbered by longjmp.  */
     volatile int forkin, forkout;
     volatile int pty_flag = 0;
  -#ifndef USE_CRT_DLL
  -  extern char **environ;
  -#endif

     inchannel = outchannel = -1;




       reply	other threads:[~2012-08-20  2:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.445588.1345421843.854.emacs-diffs@gnu.org>
2012-08-20  2:54 ` Eli Zaretskii [this message]
2012-08-20  4:05   ` /srv/bzr/emacs/trunk r109685: Rely on <unistd.h> to declare 'environ' Paul Eggert
2012-08-20 16:49     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83d32mclxb.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).