From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: (0 <= i && i < N) is not "backwards" Date: Mon, 25 Mar 2013 10:20:06 +0200 Message-ID: <83d2un3n7t.fsf@gnu.org> References: <514F88E9.2020600@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1364199634 4908 80.91.229.3 (25 Mar 2013 08:20:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 25 Mar 2013 08:20:34 +0000 (UTC) Cc: schwab@linux-m68k.org, Emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 25 09:20:57 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UK2eG-0003pL-MO for ged-emacs-devel@m.gmane.org; Mon, 25 Mar 2013 09:20:56 +0100 Original-Received: from localhost ([::1]:34054 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UK2ds-00069X-DQ for ged-emacs-devel@m.gmane.org; Mon, 25 Mar 2013 04:20:32 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56328) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UK2dN-0005aR-E8 for Emacs-devel@gnu.org; Mon, 25 Mar 2013 04:20:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UK2dK-00005t-CE for Emacs-devel@gnu.org; Mon, 25 Mar 2013 04:20:01 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:50591) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UK2dK-00005W-4M for Emacs-devel@gnu.org; Mon, 25 Mar 2013 04:19:58 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MK700J00ISKMA00@a-mtaout22.012.net.il> for Emacs-devel@gnu.org; Mon, 25 Mar 2013 10:19:57 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MK700IB9J58RON0@a-mtaout22.012.net.il>; Mon, 25 Mar 2013 10:19:57 +0200 (IST) In-reply-to: <514F88E9.2020600@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.172 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:158117 Archived-At: > Date: Sun, 24 Mar 2013 16:14:49 -0700 > From: Paul Eggert > Cc: Emacs Development > > Emacs trunk bzr 112126, installed with the commit log > "Reorder conditions that are written backwards", > changed a lot of Emacs code, typically to replace expressions > like "0 < i" with expressions like "i > 0". > > This sort of stylistic change shouldn't be introduced without > discussion. Out of fairness, you introduced this style into Emacs sources in the first place without any discussions that I could remember or find in the archives. If we want to discuss stylistic changes before committing them, let's do that no matter who is the committer. > In one or two places the change may have introduced a bug, > as "! (0 < X)" is not equivalent to "X <= 0" when > X is floating point, because of NaNs. If we want our code to be robust in the face of NaNs, we should probably use 'isnan' explicitly, because (as you know very well) every comparison with a NaN yields zero, a.k.a. false. OTOH, whether a NaN should be considered greater or less than zero in the Emacs context is debatable, IMO.