From: Eli Zaretskii <eliz@gnu.org>
To: esr@thyrsus.com
Cc: emacs-devel@gnu.org
Subject: Re: VCSWITNESS = fail ** 2
Date: Sun, 12 Jan 2014 19:36:20 +0200 [thread overview]
Message-ID: <83d2jx85m3.fsf@gnu.org> (raw)
In-Reply-To: <20140112164520.GA6770@thyrsus.com>
> Date: Sun, 12 Jan 2014 11:45:20 -0500
> From: "Eric S. Raymond" <esr@thyrsus.com>
> Cc: emacs-devel@gnu.org
>
> Eli Zaretskii <eliz@gnu.org>:
> > Shouldn't that be
> >
> > VCSWITNESS="$vcswitness"
> >
> > instead?
>
> No. You're in a Makefile context. The $$ needs to be doubled or
> it won't be passed to the shell. I tested this.
Right, the problem was elsewhere. This fixed it, AFAICS:
- vcswitness='$$(srcdir)/../'$$dirstate; \
+ vcswitness='$(srcdir)/../'$$dirstate; \
> > That possibility was considered and rejected, for the reasons that
> > Stefan explained.
>
> I have not seen that explanation.
Here it is:
> - "make autoloads" causes an undesirable re-dump even when no autoload changed.
> - for that reason "autoloads" is not in the dependencies and is not
> always run.
>
> So the vcswitness is a completely opportunistic hack which forces
> a "make autoloads" every once in a while.
> > So you have just made things worse, not better.
>
> The code wasn't working, so deleting it didn't leave us any worse
> off.
The situation with refreshing loaddefs.el became worse, see above.
next prev parent reply other threads:[~2014-01-12 17:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-12 14:37 VCSWITNESS = fail ** 2 Eric S. Raymond
2014-01-12 15:02 ` Lars Magne Ingebrigtsen
2014-01-12 15:17 ` Eric S. Raymond
2014-01-12 17:28 ` Eli Zaretskii
2014-01-12 16:27 ` Eli Zaretskii
2014-01-12 16:45 ` Eric S. Raymond
2014-01-12 17:36 ` Eli Zaretskii [this message]
2014-01-12 18:04 ` Eli Zaretskii
2014-01-12 18:45 ` Eric S. Raymond
2014-01-12 18:53 ` Eli Zaretskii
2014-01-12 19:10 ` Glenn Morris
2014-01-12 21:00 ` Eli Zaretskii
2014-01-13 2:31 ` Glenn Morris
2014-01-12 19:25 ` David Kastrup
2014-01-12 19:42 ` Eric S. Raymond
2014-01-12 20:02 ` David Kastrup
2014-01-12 21:04 ` Eli Zaretskii
2014-01-13 15:41 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83d2jx85m3.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=esr@thyrsus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).