From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Omitting Windows-specific parts from infrastructure changes Date: Wed, 21 Jan 2015 17:48:38 +0200 Message-ID: <83d268w2w9.fsf@gnu.org> References: <838uh32gpg.fsf@gnu.org> <54B9D960.1000001@cs.ucla.edu> <834mrp24b1.fsf@gnu.org> <54BBF6E7.3090802@cs.ucla.edu> <83a91gymld.fsf@gnu.org> <54BC08B2.8070302@cs.ucla.edu> <837fwjzx5f.fsf@gnu.org> <54BC18B9.50202@cs.ucla.edu> <83y4oyycz8.fsf@gnu.org> <54BD4657.3010202@cs.ucla.edu> <83egqqy637.fsf@gnu.org> <54BD81C4.1070109@cs.ucla.edu> <833875xvin.fsf@gnu.org> <54BEC86A.7060605@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1421855431 6004 80.91.229.3 (21 Jan 2015 15:50:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 21 Jan 2015 15:50:31 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 21 16:50:31 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YDxY6-0001Kw-BY for ged-emacs-devel@m.gmane.org; Wed, 21 Jan 2015 16:50:30 +0100 Original-Received: from localhost ([::1]:48867 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDxY5-0003uO-RV for ged-emacs-devel@m.gmane.org; Wed, 21 Jan 2015 10:50:29 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56780) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDxXf-0003lM-0L for emacs-devel@gnu.org; Wed, 21 Jan 2015 10:50:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YDxXZ-00008q-NB for emacs-devel@gnu.org; Wed, 21 Jan 2015 10:50:02 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:32800) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDxXZ-000081-Ci for emacs-devel@gnu.org; Wed, 21 Jan 2015 10:49:57 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NIJ00K009MSKT00@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Wed, 21 Jan 2015 17:48:42 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NIJ00KDYAL5HC70@a-mtaout20.012.net.il>; Wed, 21 Jan 2015 17:48:42 +0200 (IST) In-reply-to: <54BEC86A.7060605@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:181505 Archived-At: > Date: Tue, 20 Jan 2015 13:28:10 -0800 > From: Paul Eggert > CC: emacs-devel@gnu.org > > it still works, in the places where the MS-Windows code still uses strcat > instead of stpcpy. > > Beg your pardon, but how do you know this? > > Because I made an extra effort to check, as part of following up this conversation. Which changeset did you check? There were quite a few of them. It could be that some of them didn't break anything, but some certainly did. And leaving portions of Emacs out of the set of files that is kept in good shape is bad for maintenance, so even changes that don't break need to be made everywhere, at least as a goal. > just post those notes once when you first do the examination > > I don't have any notes to post. I don't write notes for this sort of thing. "Notes" is just a word. I'm asking you to post the information that can be used by someone else to find the places which you omitted from the scope of your changes. That information is certainly available to you when you are working on the changeset, so just publish it whenever it's the most convenient moment for you. > Honestly, I don't see why this is such a big deal. Anyone who's curious about uses of strcat in the MS-Windows code can easily search the code for instances of the string "strcat". _After_ we know that the changeset had to deal with strcat following strcpy, yes, it's a simple thing to find those places. But that's exactly what I'm asking you to publish -- the description of what to look for, either as plain text or as a script that does the job, if you used such a script and have it available. Without this information, one has to somehow glean it by reverse-engineering your commits. Which is not easy, because they are complex and quite often include changes not directly related to the main issue of the changeset. So this process is error-prone and takes precious time. Take your suggested changes in bug#19634: I think you left out at least one place in w32 files, but I cannot be sure without knowing calls to which functions should be converted to use CALLN. I need to read a 1800-odd line patch to try to understand that, whereas it would have taken you no more than a single sentence to describe that clearly. Honestly, I don't see why it's such a big deal to make this job much easier by simply publishing the information that is clear to you and at your fingertips when you work on the changeset. It is a very small overhead for you, and a huge benefit for me. So I'm asking you to please humor me with this small favor. > And if nobody bothers to do the search, that's fine too. That might be your personal goal, but please don't punish your fellow developers that happen to disagree with you on that. We all have our personal preferences, but we shouldn't go after fellow developers whose preferences are different. If we do, what kind of team are we?