From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 58e6235: * lisp/image-mode.el: Support encrypted file Date: Tue, 17 Nov 2015 18:11:13 +0200 Message-ID: <83d1v8bo7y.fsf@gnu.org> References: <20151117024921.17288.30331@vcs.savannah.gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1447776724 26372 80.91.229.3 (17 Nov 2015 16:12:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 17 Nov 2015 16:12:04 +0000 (UTC) Cc: ueno@gnu.org, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 17 17:11:55 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zyiqt-0007GZ-Ku for ged-emacs-devel@m.gmane.org; Tue, 17 Nov 2015 17:11:27 +0100 Original-Received: from localhost ([::1]:59286 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zyiqt-0002Mb-1J for ged-emacs-devel@m.gmane.org; Tue, 17 Nov 2015 11:11:27 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zyiqp-0002MW-8I for emacs-devel@gnu.org; Tue, 17 Nov 2015 11:11:24 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zyiqj-0005tl-7e for emacs-devel@gnu.org; Tue, 17 Nov 2015 11:11:23 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:34816) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zyiqi-0005tb-Vw; Tue, 17 Nov 2015 11:11:17 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NXY00F00V263I00@a-mtaout20.012.net.il>; Tue, 17 Nov 2015 18:11:14 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NXY00E8PVMQZN40@a-mtaout20.012.net.il>; Tue, 17 Nov 2015 18:11:14 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:194648 Archived-At: > From: Stefan Monnier > Date: Mon, 16 Nov 2015 23:56:34 -0500 > Cc: Daiki Ueno > > > @@ -658,7 +658,12 @@ was inserted." > > (not (and (boundp 'archive-superior-buffer) > > archive-superior-buffer)) > > (not (and (boundp 'tar-superior-buffer) > > - tar-superior-buffer))))) > > + tar-superior-buffer)) > > + ;; This means the buffer holds the > > + ;; decrypted content (bug#21870). > > + (not (and (boundp 'epa-file-encrypt-to) > > + (local-variable-p > > + 'epa-file-encrypt-to)))))) > > (file-or-data (if data-p > > (string-make-unibyte > > (buffer-substring-no-properties (point-min) (point-max))) > > Clearly, image-mode should not need to know about tar-mode, > archive-mode, nor epa-mode, and instead there should be a way for those > to indicate that the buffer's content is not available in the file via > normal syscalls. If that can be done with a localized, safe change, it should be okay to do that on the emacs-25 branch. Failing that, the branch will have to live with the above, and the better solution should go to master. P.S. This code is there since 6 years ago.