* Re: [Emacs-diffs] master 58e6235: * lisp/image-mode.el: Support encrypted file
[not found] ` <E1ZyWKf-0004VW-Bi@vcs.savannah.gnu.org>
@ 2015-11-17 4:56 ` Stefan Monnier
2015-11-17 16:11 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2015-11-17 4:56 UTC (permalink / raw
To: emacs-devel; +Cc: Daiki Ueno
> @@ -658,7 +658,12 @@ was inserted."
> (not (and (boundp 'archive-superior-buffer)
> archive-superior-buffer))
> (not (and (boundp 'tar-superior-buffer)
> - tar-superior-buffer)))))
> + tar-superior-buffer))
> + ;; This means the buffer holds the
> + ;; decrypted content (bug#21870).
> + (not (and (boundp 'epa-file-encrypt-to)
> + (local-variable-p
> + 'epa-file-encrypt-to))))))
> (file-or-data (if data-p
> (string-make-unibyte
> (buffer-substring-no-properties (point-min) (point-max)))
Clearly, image-mode should not need to know about tar-mode,
archive-mode, nor epa-mode, and instead there should be a way for those
to indicate that the buffer's content is not available in the file via
normal syscalls.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Emacs-diffs] master 58e6235: * lisp/image-mode.el: Support encrypted file
2015-11-17 4:56 ` [Emacs-diffs] master 58e6235: * lisp/image-mode.el: Support encrypted file Stefan Monnier
@ 2015-11-17 16:11 ` Eli Zaretskii
2015-11-17 16:52 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2015-11-17 16:11 UTC (permalink / raw
To: Stefan Monnier; +Cc: ueno, emacs-devel
> From: Stefan Monnier <monnier@IRO.UMontreal.CA>
> Date: Mon, 16 Nov 2015 23:56:34 -0500
> Cc: Daiki Ueno <ueno@gnu.org>
>
> > @@ -658,7 +658,12 @@ was inserted."
> > (not (and (boundp 'archive-superior-buffer)
> > archive-superior-buffer))
> > (not (and (boundp 'tar-superior-buffer)
> > - tar-superior-buffer)))))
> > + tar-superior-buffer))
> > + ;; This means the buffer holds the
> > + ;; decrypted content (bug#21870).
> > + (not (and (boundp 'epa-file-encrypt-to)
> > + (local-variable-p
> > + 'epa-file-encrypt-to))))))
> > (file-or-data (if data-p
> > (string-make-unibyte
> > (buffer-substring-no-properties (point-min) (point-max)))
>
> Clearly, image-mode should not need to know about tar-mode,
> archive-mode, nor epa-mode, and instead there should be a way for those
> to indicate that the buffer's content is not available in the file via
> normal syscalls.
If that can be done with a localized, safe change, it should be okay
to do that on the emacs-25 branch. Failing that, the branch will have
to live with the above, and the better solution should go to master.
P.S. This code is there since 6 years ago.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Emacs-diffs] master 58e6235: * lisp/image-mode.el: Support encrypted file
2015-11-17 16:11 ` Eli Zaretskii
@ 2015-11-17 16:52 ` Stefan Monnier
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2015-11-17 16:52 UTC (permalink / raw
To: Eli Zaretskii; +Cc: ueno, emacs-devel
> If that can be done with a localized, safe change, it should be okay
> to do that on the emacs-25 branch. Failing that, the branch will have
> to live with the above, and the better solution should go to master.
> P.S. This code is there since 6 years ago.
My comment was indeed not a criticism of the change.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-17 16:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20151117024921.17288.30331@vcs.savannah.gnu.org>
[not found] ` <E1ZyWKf-0004VW-Bi@vcs.savannah.gnu.org>
2015-11-17 4:56 ` [Emacs-diffs] master 58e6235: * lisp/image-mode.el: Support encrypted file Stefan Monnier
2015-11-17 16:11 ` Eli Zaretskii
2015-11-17 16:52 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).