unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: ueno@gnu.org, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 58e6235: * lisp/image-mode.el: Support	encrypted file
Date: Tue, 17 Nov 2015 18:11:13 +0200	[thread overview]
Message-ID: <83d1v8bo7y.fsf@gnu.org> (raw)
In-Reply-To: <jwvk2phi5sa.fsf-monnier+emacsdiffs@gnu.org>

> From: Stefan Monnier <monnier@IRO.UMontreal.CA>
> Date: Mon, 16 Nov 2015 23:56:34 -0500
> Cc: Daiki Ueno <ueno@gnu.org>
> 
> > @@ -658,7 +658,12 @@ was inserted."
> >  			   (not (and (boundp 'archive-superior-buffer)
> >  				     archive-superior-buffer))
> >  			   (not (and (boundp 'tar-superior-buffer)
> > -				     tar-superior-buffer)))))
> > +				     tar-superior-buffer))
> > +                           ;; This means the buffer holds the
> > +                           ;; decrypted content (bug#21870).
> > +                           (not (and (boundp 'epa-file-encrypt-to)
> > +                                     (local-variable-p
> > +                                      'epa-file-encrypt-to))))))
> >  	 (file-or-data (if data-p
> >  			   (string-make-unibyte
> >  			    (buffer-substring-no-properties (point-min) (point-max)))
> 
> Clearly, image-mode should not need to know about tar-mode,
> archive-mode, nor epa-mode, and instead there should be a way for those
> to indicate that the buffer's content is not available in the file via
> normal syscalls.

If that can be done with a localized, safe change, it should be okay
to do that on the emacs-25 branch.  Failing that, the branch will have
to live with the above, and the better solution should go to master.

P.S. This code is there since 6 years ago.



  reply	other threads:[~2015-11-17 16:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20151117024921.17288.30331@vcs.savannah.gnu.org>
     [not found] ` <E1ZyWKf-0004VW-Bi@vcs.savannah.gnu.org>
2015-11-17  4:56   ` [Emacs-diffs] master 58e6235: * lisp/image-mode.el: Support encrypted file Stefan Monnier
2015-11-17 16:11     ` Eli Zaretskii [this message]
2015-11-17 16:52       ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83d1v8bo7y.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    --cc=ueno@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).