From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tom@tromey.com>
Cc: aurelien.aptel+emacs@gmail.com, p.stephani2@gmail.com,
dancol@dancol.org, tzz@lifelogs.com, emacs-devel@gnu.org
Subject: Re: Dynamic modules: emacs-module.c and signaling errors
Date: Tue, 24 Nov 2015 22:49:07 +0200 [thread overview]
Message-ID: <83d1uzxgvw.fsf@gnu.org> (raw)
In-Reply-To: <87wpt7p369.fsf@tromey.com>
> From: Tom Tromey <tom@tromey.com>
> Cc: Philipp Stephani <p.stephani2@gmail.com>, aurelien.aptel+emacs@gmail.com, tzz@lifelogs.com, dancol@dancol.org, emacs-devel@gnu.org
> Date: Tue, 24 Nov 2015 13:12:30 -0700
>
> What I did in my module is do an error check after every call in to
> Emacs, returning early when one is seen. Then eventually control
> returns to Fmodule_call, which handles translating this to a Lisp
> signal.
Thanks. However, this is highly non-obvious, and IMO quite error
prone. The consequences of failing to conform to this paradigm are
dire: the error goes unreported, and instead an unrelated assertion
blows up.
Perhaps we should remove these assertions, or at least make them
conditional on something that isn't ENABLE_CHECKING, since it seems
they were added for debugging emacs-module.c, not for catching errors
in modules.
Btw, using this method the module code becomes very tedious, something
like
intmax_t a = env->extract_integer (env, args[0]);
if (env->non_local_exit_check (env) != emacs_funcall_exit_return)
return NULL;
intmax_t b = env->extract_integer (env, args[1]);
if (env->non_local_exit_check (env) != emacs_funcall_exit_return)
return NULL;
etc.
next prev parent reply other threads:[~2015-11-24 20:49 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 19:41 Dynamic modules: emacs-module.c and signaling errors Eli Zaretskii
2015-11-24 19:45 ` Eli Zaretskii
2015-11-24 20:12 ` Tom Tromey
2015-11-24 20:49 ` Eli Zaretskii [this message]
2015-11-24 21:34 ` Paul Eggert
2015-11-24 21:55 ` Daniel Colascione
2015-11-25 6:52 ` Paul Eggert
2015-11-25 7:03 ` Daniel Colascione
2015-11-25 7:14 ` Paul Eggert
2015-11-25 7:18 ` Daniel Colascione
2015-11-25 7:23 ` Paul Eggert
2015-11-25 7:25 ` Daniel Colascione
2015-11-25 7:49 ` Paul Eggert
2015-11-25 7:52 ` Daniel Colascione
2015-11-25 7:58 ` Paul Eggert
2015-11-25 8:12 ` Daniel Colascione
2015-11-25 8:24 ` Paul Eggert
2015-11-25 8:50 ` Daniel Colascione
2015-11-25 9:11 ` Daniel Colascione
2015-11-25 18:19 ` Eli Zaretskii
2015-11-25 18:26 ` Philipp Stephani
2015-11-25 19:19 ` Eli Zaretskii
2015-11-25 21:52 ` Philipp Stephani
2015-11-25 17:34 ` Paul Eggert
2015-11-24 22:21 ` Tom Tromey
2015-11-25 6:55 ` Paul Eggert
2015-11-25 17:30 ` Eli Zaretskii
2015-11-25 17:34 ` Paul Eggert
2015-11-25 21:23 ` Stefan Monnier
2015-11-26 15:42 ` Eli Zaretskii
2015-11-26 16:36 ` Stefan Monnier
2015-11-26 17:08 ` Eli Zaretskii
2015-11-26 19:28 ` Stefan Monnier
2015-11-26 19:34 ` Eli Zaretskii
2015-11-26 20:11 ` Stefan Monnier
2015-11-26 20:19 ` Eli Zaretskii
2015-11-26 21:20 ` Paul Eggert
2015-11-26 22:29 ` Philipp Stephani
2015-11-26 22:33 ` Philipp Stephani
2015-11-27 1:06 ` Stefan Monnier
2015-11-27 1:10 ` Daniel Colascione
2015-11-27 15:06 ` Stefan Monnier
2015-11-27 8:12 ` Eli Zaretskii
2015-11-27 9:11 ` Eli Zaretskii
2015-11-27 12:25 ` Aurélien Aptel
2015-11-27 14:44 ` Eli Zaretskii
2015-11-28 23:31 ` Paul Eggert
2015-11-27 1:21 ` Stefan Monnier
2015-11-27 8:26 ` Eli Zaretskii
2015-11-27 15:15 ` Stefan Monnier
2015-11-27 15:57 ` Eli Zaretskii
2015-11-27 16:29 ` Stefan Monnier
2015-11-27 17:38 ` Eli Zaretskii
2015-11-27 17:54 ` Stefan Monnier
2015-11-25 18:10 ` Tom Tromey
2015-11-25 18:15 ` Eli Zaretskii
2015-11-25 18:09 ` Philipp Stephani
2015-11-25 21:19 ` Stefan Monnier
2015-11-26 15:41 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83d1uzxgvw.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=aurelien.aptel+emacs@gmail.com \
--cc=dancol@dancol.org \
--cc=emacs-devel@gnu.org \
--cc=p.stephani2@gmail.com \
--cc=tom@tromey.com \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).