From: Eli Zaretskii <eliz@gnu.org>
To: Yuan MEI <yuan.mei.list@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Redisplay issue
Date: Wed, 02 Dec 2015 15:57:06 +0200 [thread overview]
Message-ID: <83d1upj6ml.fsf@gnu.org> (raw)
In-Reply-To: <CANGGyWbAEZ7KxMFZeyWCJUDjmGYBzjZypxBp1pWgq63FnSN1iw@mail.gmail.com>
> Date: Tue, 1 Dec 2015 20:35:43 -0800
> From: Yuan MEI <yuan.mei.list@gmail.com>
> Cc: emacs-devel <emacs-devel@gnu.org>
>
> > I have only one more idea: can you build Emacs without Cairo? Cairo
> > changes the way Emacs draws the screen in significant ways, and that
> > is the only part of this puzzle that we didn't verify yet. The traces
> > indicate that everything up to the point where we invoke the drawing
> > code is identical between the "good" and the "bad" cases, and
> > correctly instructs the display back-end to redraw every screen line
> > in the exposed region(s).
>
> Very interesting. The partial redraw problem seems to be gone when
> cairo is disabled. I couldn't reproduce the bad case any more.
> However I encountered another bug when cairo is disabled: did C-h h to
> bring up HELLO, and Emacs crashed:
>
> lisp.h:1543: Emacs fatal error: assertion failed: 0 <= size
> Fatal error 6: Aborted
> lisp.h:1543: Emacs fatal error: assertion failed: 0 <= size
> Aborted
When did you last update from the repository? I believe this bug was
solved a week ago, in commit d5fdffecdfad305d9c933ae3cad75a5e4e73878c.
If your sources include the changes in that commit, please show a GDB
backtrace when Emacs aborts.
A stub in the dark: does the change below fix the Cairo build, per
chance?
diff --git a/src/xdisp.c b/src/xdisp.c
index d1a10ca..7221032 100644
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -30268,6 +30268,7 @@ expose_area (struct window *w, struct glyph_row *row, XRectangle *r,
struct glyph *last;
int first_x, start_x, x;
+ block_input ();
if (area == TEXT_AREA && row->fill_line_p)
/* If row extends face to end of line write the whole line. */
draw_glyphs (w, 0, row, area,
@@ -30310,6 +30311,7 @@ expose_area (struct window *w, struct glyph_row *row, XRectangle *r,
first - row->glyphs[area], last - row->glyphs[area],
DRAW_NORMAL_TEXT, 0);
}
+ unblock_input ();
}
next prev parent reply other threads:[~2015-12-02 13:57 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 22:31 Redisplay issue Yuan MEI
2015-11-28 8:06 ` Eli Zaretskii
2015-11-28 8:27 ` Yuan MEI
2015-11-28 9:44 ` Eli Zaretskii
2015-11-28 20:19 ` Yuan MEI
2015-11-28 20:49 ` Eli Zaretskii
2015-11-29 2:54 ` Yuan MEI
2015-11-29 15:42 ` Eli Zaretskii
2015-11-29 23:35 ` Yuan MEI
2015-11-30 16:16 ` Eli Zaretskii
2015-12-01 4:51 ` Yuan MEI
2015-12-01 16:01 ` Eli Zaretskii
2015-12-02 4:35 ` Yuan MEI
2015-12-02 13:57 ` Eli Zaretskii [this message]
2015-12-03 4:55 ` Yuan MEI
2015-12-03 7:47 ` Eli Zaretskii
2015-12-03 8:09 ` Yuan MEI
2015-12-03 10:23 ` Eli Zaretskii
2015-12-03 18:16 ` martin rudalics
2015-12-03 21:23 ` Yuan MEI
2015-12-04 8:08 ` martin rudalics
2015-12-04 8:30 ` Yuan MEI
2015-12-04 8:48 ` martin rudalics
2015-12-04 8:54 ` Yuan MEI
2015-12-04 8:56 ` martin rudalics
2015-12-04 9:00 ` Yuan MEI
2015-12-04 9:05 ` martin rudalics
2015-12-04 9:47 ` Eli Zaretskii
2015-12-04 10:21 ` martin rudalics
2015-12-04 11:01 ` Eli Zaretskii
2015-12-04 11:12 ` Eli Zaretskii
2015-12-05 0:25 ` YAMAMOTO Mitsuharu
2015-12-05 9:17 ` Eli Zaretskii
2015-12-06 0:49 ` Yuan MEI
2015-12-07 3:33 ` YAMAMOTO Mitsuharu
2015-12-07 17:19 ` Eli Zaretskii
2015-12-08 4:03 ` YAMAMOTO Mitsuharu
2015-12-11 8:48 ` Eli Zaretskii
2015-11-28 21:44 ` joakim
2015-11-29 0:14 ` Yuan MEI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83d1upj6ml.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=yuan.mei.list@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).