From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Please add comments to isearch.el Date: Sat, 12 Dec 2015 09:25:05 +0200 Message-ID: <83d1uc6sdq.fsf@gnu.org> References: <83fuzoojcn.fsf@gnu.org> <83poyd8kta.fsf@gnu.org> <20151211121617.GA3351@acm.fritz.box> <83y4d16txk.fsf@gnu.org> <83lh916jpp.fsf@gnu.org> <871tasbnhh.fsf@mail.linkov.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1449905124 9849 80.91.229.3 (12 Dec 2015 07:25:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 12 Dec 2015 07:25:24 +0000 (UTC) Cc: acm@muc.de, bruce.connor.am@gmail.com, emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 12 08:25:15 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a7eYM-00057D-H5 for ged-emacs-devel@m.gmane.org; Sat, 12 Dec 2015 08:25:14 +0100 Original-Received: from localhost ([::1]:50849 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7eYL-00078R-91 for ged-emacs-devel@m.gmane.org; Sat, 12 Dec 2015 02:25:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40444) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7eY9-00078I-LV for emacs-devel@gnu.org; Sat, 12 Dec 2015 02:25:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a7eY6-0000gQ-Ez for emacs-devel@gnu.org; Sat, 12 Dec 2015 02:25:01 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:39159) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7eY6-0000fT-71 for emacs-devel@gnu.org; Sat, 12 Dec 2015 02:24:58 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NZ800A00H3DW200@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Sat, 12 Dec 2015 09:24:57 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NZ800AX4HXKXS00@a-mtaout20.012.net.il>; Sat, 12 Dec 2015 09:24:57 +0200 (IST) In-reply-to: <871tasbnhh.fsf@mail.linkov.net> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:196159 Archived-At: > From: Juri Linkov > Date: Sat, 12 Dec 2015 00:59:38 +0200 > Cc: Alan Mackenzie , Eli Zaretskii , > emacs-devel > > > I don't mind breaking things on master. > > The point is that Isearch is probably one of the most used emacs features. > > I expect there are lots of packages out there using its api. I'm not sure > > overhauling it would be worth the pain it would cause to everyone who's > > maintaining/using those packages. > > +1 > > For example, the recent removal of a layer of indirection for lax-whitespace > broke customizations that allowed overriding search-forward-lax-whitespace > with own implementation to ignore all possible whitespace instead of > just spaces in the search string. Hey, I didn't suggest refactoring to begin with. I suggested to add commentary to explain how things work there. The example you give is just another confirmation of my observation that the code in isearch.el has long ago crossed the line of being unmaintainable, and I think we should fix that ASAP. Thanks.