From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 504696d: Etags: yet another improvement in Ruby tags Date: Fri, 05 Feb 2016 13:15:45 +0200 Message-ID: <83d1sbv25a.fsf@gnu.org> References: <20160203162536.2954.45438@vcs.savannah.gnu.org> <56B29165.3040404@yandex.ru> <8337t9xhjc.fsf@gnu.org> <56B31B99.6010400@yandex.ru> <83io24wfjl.fsf@gnu.org> <56B4329D.7010101@yandex.ru> <83mvrfv7s3.fsf@gnu.org> <56B47566.5090806@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1454670989 14172 80.91.229.3 (5 Feb 2016 11:16:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 5 Feb 2016 11:16:29 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 05 12:16:24 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aReN9-0007rb-QT for ged-emacs-devel@m.gmane.org; Fri, 05 Feb 2016 12:16:19 +0100 Original-Received: from localhost ([::1]:47613 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aReN9-0001iV-70 for ged-emacs-devel@m.gmane.org; Fri, 05 Feb 2016 06:16:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48093) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aReMq-0001iC-H3 for emacs-devel@gnu.org; Fri, 05 Feb 2016 06:16:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aReMl-0007bb-F4 for emacs-devel@gnu.org; Fri, 05 Feb 2016 06:16:00 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49903) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aReMl-0007bX-BD; Fri, 05 Feb 2016 06:15:55 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1516 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aReMk-0007z9-Lx; Fri, 05 Feb 2016 06:15:55 -0500 In-reply-to: <56B47566.5090806@yandex.ru> (message from Dmitry Gutov on Fri, 5 Feb 2016 13:11:50 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:199373 Archived-At: > Cc: emacs-devel@gnu.org > From: Dmitry Gutov > Date: Fri, 5 Feb 2016 13:11:50 +0300 > > On 02/05/2016 12:14 PM, Eli Zaretskii wrote: > > > No. What comes after the comma must begin with attr_SOMETHING or > > alias_method. The issue being tested here is that we are not in a > > state where matches for these are being tried. > > alias_method :qux, :tee, attr_accessor(:bogus) > > or > > alias_method :qux, :tee, alias_method(:bogus, :bogus2) > > are the main options, I suppose. These should work for my purposes. > But they might also look misleading, and indicate that we don't > support the paren-using syntax intentionally. > > (It's another omission, but AFAICS nobody uses attr_XXX without parens > in the context we're interested in.) If it's important to support that, it should be hard to add. > > But if you ever figure out how to do that with a less abnormal syntax, > > feel free to update the test files. > > The problem with me updating the tests is I can't revert the > corresponding fix and make sure that the test fails without it. You can always leave that to me. > > It could also be a good idea to add a Rakefile or a Thorfile to the > > ruby-src directory (when I tested the change, I just renamed one of > > the other files). It could be that those present special challenges, > > and in any case we should test the file-name rules. > > I believe the file-name rules should be tested in a language-agnostic > way, or just with one language. I don't see how: the file names that trigger recognition as a specific language are part of the language-specific rules. IOW, when etags sees a file whose basename is "Rakefile", it should process it as a Ruby file, and how can you test it does that without actually looking at the tags it produces for that file? E.g., the bug I fixed in f6213ce caused Makefile's to be processed as Fortran sources... > We're probably better in some things, and worse in others, than "Ripper > Tags" [3]. I haven't tried them yet myself. Maybe etags should acquire a feature whereby it could run external programs to help it find the tags. Something to think of for future projects, perhaps.