unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: bug-gnulib@gnu.org, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master updated (3c586e1 -> 0bbf00c)
Date: Fri, 16 Sep 2016 11:32:52 +0300	[thread overview]
Message-ID: <83d1k45jnv.fsf@gnu.org> (raw)
In-Reply-To: <803a917e-3184-d0fc-16ec-580f7acd54ab@cs.ucla.edu> (message from Paul Eggert on Fri, 16 Sep 2016 00:58:04 -0700)

> Cc: emacs-devel@gnu.org, Gnulib bugs <bug-gnulib@gnu.org>
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Fri, 16 Sep 2016 00:58:04 -0700
> 
> > I don't like the idea that Gnulib should dictate whether Emacs uses
> > this MinGW feature or not.  If there are good reasons for that (can
> > you tell what they are?),
> 
> Setting __USE_MINGW_ANSI_STDIO is part of Gnulib's usual desire to support a 
> GNU-like environment even on non-GNU hosts.

Ah, okay.  My interpretation of that is that we don't need to define
that symbol, as long as there's no specific reason why we should do
so.  When we decide to use it, it should be defined in nt/inc/ms-w32.h
before _mingw.h is included.

> Formerly, defining __USE_MINGW_ANSI_STDIO to 1 was done by 
> AC_USE_SYSTEM_EXTENSIONS (defined in m4/extensions.m4), but as this is not 
> really a system extension I recently moved that definition to gl_STDIO_H 
> (defined in m4/stdio_h.m4). When I did this I used a simple AC_DEFINE to 1, as I 
> assumed this would suffice. Evidently it does not work for Emacs, so I just now 
> adjusted the moved version in Emacs master (and in Gnulib) to look more like the 
> original, as per the attached Emacs patch.

Thanks, the warnings are gone.



      reply	other threads:[~2016-09-16  8:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-16  7:07 [Emacs-diffs] master updated (3c586e1 -> 0bbf00c) Eli Zaretskii
2016-09-16  7:58 ` Paul Eggert
2016-09-16  8:32   ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83d1k45jnv.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=bug-gnulib@gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).