From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Byte-compilation of custom themes Date: Sat, 02 Jun 2018 14:24:09 +0300 Message-ID: <83d0x9e8iu.fsf@gnu.org> References: <87efmk2qk0.fsf@tcd.ie> <87vafjhu04.fsf@tcd.ie> <87po5po7ul.fsf@tcd.ie> <87o9hoxm0w.fsf@tcd.ie> <83fu2ynvda.fsf@gnu.org> <87zi169q9y.fsf@tcd.ie> <83a7t6nlmf.fsf@gnu.org> <877eo9kjnl.fsf@tcd.ie> <831sehnymt.fsf@gnu.org> <874lim2pyi.fsf@tcd.ie> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1527938532 14466 195.159.176.226 (2 Jun 2018 11:22:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 2 Jun 2018 11:22:12 +0000 (UTC) Cc: monnier@IRO.UMontreal.CA, emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 02 13:22:07 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fP4bn-0003eB-Mc for ged-emacs-devel@m.gmane.org; Sat, 02 Jun 2018 13:22:07 +0200 Original-Received: from localhost ([::1]:59201 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fP4dt-0001mO-67 for ged-emacs-devel@m.gmane.org; Sat, 02 Jun 2018 07:24:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fP4dm-0001mJ-IJ for emacs-devel@gnu.org; Sat, 02 Jun 2018 07:24:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fP4di-0004UL-G9 for emacs-devel@gnu.org; Sat, 02 Jun 2018 07:24:10 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44489) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fP4di-0004U6-Ch; Sat, 02 Jun 2018 07:24:06 -0400 Original-Received: from [176.228.60.248] (port=2166 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fP4dh-0003H7-Pj; Sat, 02 Jun 2018 07:24:06 -0400 In-reply-to: <874lim2pyi.fsf@tcd.ie> (contovob@tcd.ie) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:225919 Archived-At: > From: "Basil L. Contovounesios" > Cc: , > Date: Fri, 01 Jun 2018 21:48:21 +0100 > > >> Do you mean a cl-assertion, or an emulation thereof? > > > > I meant cl-assert. > > Unless I (being unfamiliar with the subtleties of the build and > bootstrap process) am missing something, I think it's too early to load > cl-lib here; at least 'make bootstrap' fails for me when I add > (eval-when-compile (require 'cl-lib)) to custom.el. Is there a way > around this? Yes, explicitly check whether cl-lib is available, and skip the call if not. We don't need this assertion during the bootstrap. > >> Either way, what is the benefit of barfing before directory-files does? > > > > That you can control the text of the error message, and make it more > > user-friendly. Also, an assertion clearly means we intended this not > > to happen, rather than that the code failed to handle some valid > > situation. > > Understood. I've noticed, however, that many, if not most, uses of > cl-assert don't specify a custom error message. For future reference, > is this acceptable practice, or would we rather see consistent use of > more informative messages? My preference is clear from the above, but I don't have enough experience to answer the rest of your question. Thanks.