unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: harfbuzz 2f72162: Fix crash in the Cairo build
Date: Fri, 08 Feb 2019 23:29:38 +0200	[thread overview]
Message-ID: <83d0o2otod.fsf@gnu.org> (raw)
In-Reply-To: <m2va1umdwh.fsf@gmail.com> (message from Robert Pluim on Fri, 08 Feb 2019 17:41:02 +0100)

> From: Robert Pluim <rpluim@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Fri, 08 Feb 2019 17:41:02 +0100
> 
> >   #ifdef HAVE_FREETYPE
> >   #ifdef HAVE_XFT
> >     register_font_driver (&xftfont_driver, f);
> >   #else	/* not HAVE_XFT */
> >     register_font_driver (&ftxfont_driver, f);
> >   #endif	/* not HAVE_XFT */
> >   #endif	/* HAVE_FREETYPE */
> >     register_font_driver (&xfont_driver, f);
> >   #endif	/* not USE_CAIRO */
> >
> > Here, xftfont and ftxfont are clearly 2 more-or-less equivalent
> > alternatives, and bot rely on Freetype.  So I don't understand why not
> > having XFT is taken by configure.ac to mean there's no Freetype,
> > either.  Sounds like a mistake, or did I miss something?
> 
> Interesting. Glenn made that change in
> 46dcfee46cb241a0f8e34da679ca8b42e8ee8d46 , but thatʼs quite a while
> ago.
> 
> Like I said, we can change stuff around here, but I think the easiest
> thing to do is just get rid of it.

Is XFT sufficiently widespread these days that we can rely on it being
available on most systems?  If so, I guess it's okay to drop
ftxfont.c.



  reply	other threads:[~2019-02-08 21:29 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20181214085417.15440.18845@vcs0.savannah.gnu.org>
     [not found] ` <20181214085418.6616820538@vcs0.savannah.gnu.org>
2018-12-14 12:18   ` harfbuzz 2f72162: Fix crash in the Cairo build Robert Pluim
2018-12-14 13:29     ` Eli Zaretskii
2018-12-14 14:09       ` Robert Pluim
2018-12-14 16:16       ` Robert Pluim
2018-12-14 16:45         ` Eli Zaretskii
2018-12-17 12:41           ` Robert Pluim
2018-12-17 17:39             ` Eli Zaretskii
2018-12-18  8:49               ` Robert Pluim
2018-12-18 13:01                 ` Robert Pluim
2019-02-08  8:01               ` Robert Pluim
2019-02-08  8:04                 ` Robert Pluim
2019-02-08  8:06                   ` Robert Pluim
2019-02-08  9:37                 ` Eli Zaretskii
2019-02-08 11:46                   ` Robert Pluim
2019-02-08 13:14                     ` Eli Zaretskii
2019-02-08 14:38                       ` Robert Pluim
2019-02-08 16:11                         ` Eli Zaretskii
2019-02-08 16:41                           ` Robert Pluim
2019-02-08 21:29                             ` Eli Zaretskii [this message]
2019-02-09 19:20                               ` Glenn Morris
2019-02-09 19:34                                 ` Eli Zaretskii
2019-02-10 14:47                                   ` Stefan Monnier
2019-02-10 15:28                                     ` Eli Zaretskii
2019-02-10 18:18                                       ` Stefan Monnier
2019-02-10 18:48                                         ` Eli Zaretskii
2019-02-10 18:52                                           ` Stefan Monnier
2019-02-11  9:56                                             ` Robert Pluim
2019-02-10 18:30                                   ` Glenn Morris
2019-02-10 14:57                                 ` Eli Zaretskii
2019-02-10 18:36                                   ` Glenn Morris
2019-02-11 15:33                                     ` Eli Zaretskii
2018-12-17 21:49             ` Paul Eggert
2018-12-18  8:23               ` Robert Pluim
2018-12-19  8:32                 ` Robert Pluim
2018-12-19 15:06                   ` Eli Zaretskii
2018-12-14 20:25         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83d0o2otod.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).