From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build: arc-mode Date: Fri, 17 May 2019 15:01:27 +0300 Message-ID: <83d0khb888.fsf@gnu.org> References: Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="111786"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 17 14:02:09 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hRbYv-000Srt-J7 for ged-emacs-devel@m.gmane.org; Fri, 17 May 2019 14:02:09 +0200 Original-Received: from localhost ([127.0.0.1]:47724 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRbYu-0002KA-HM for ged-emacs-devel@m.gmane.org; Fri, 17 May 2019 08:02:08 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42041) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRbYh-0002Jq-QF for emacs-devel@gnu.org; Fri, 17 May 2019 08:02:00 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51806) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRbYh-0000Uy-MO; Fri, 17 May 2019 08:01:55 -0400 Original-Received: from [176.228.60.248] (port=1703 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hRbYf-0003A2-0f; Fri, 17 May 2019 08:01:55 -0400 In-reply-to: (message from Lars Ingebrigtsen on Fri, 17 May 2019 12:35:47 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236656 Archived-At: > From: Lars Ingebrigtsen > Date: Fri, 17 May 2019 12:35:47 +0200 > > This is the most head-scratchiest of all the string-to-multibyte stuff. > > (eval-when-compile > (defsubst byte-after (pos) > "Like char-after but an eight-bit char is converted to unibyte." > (multibyte-char-to-unibyte (char-after pos))) > (defsubst insert-unibyte (&rest args) > "Like insert but don't make unibyte string and eight-bit char multibyte." > (dolist (elt args) > (if (integerp elt) > (insert (if (< elt 128) elt (decode-char 'eight-bit elt))) > (insert (string-to-multibyte elt))))) > ) We have get-byte nowadays, so I believe the first defsubst is not needed. You just need to catch errors, maybe. > First of all, it defines defsubsts in the global namespace, but > (decode-char 'eight-bit 130) => 4194178 > > Hm... Oh! Is it working in a multibyte buffer, so it wants to insert > bytes that are in Emacs' "byte plane"? > > (insert (decode-char 'eight-bit 130)) > => \202 > > I guess. Yes. However, I suspect this juggling is no longer need nowadays. If you just use 'insert', does arc-mode break when you invoke the commands that end up using these calls? This should be tried also in a locale whose codeset is not UTF-8. Thanks.