From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: git-send-email (was: Why are so many great packages not trying to get included in GNU Emacs?) Date: Mon, 15 Jun 2020 05:37:12 +0300 Message-ID: <83d0612gx3.fsf@gnu.org> References: <875zdteybt.fsf@runbox.com> <87368wrvf5.fsf@yahoo.com> <86k126d83n.wl-me@enzu.ru> <83pnbyckvv.fsf@gnu.org> <4923d7e98f5ed816a7569093dbc673153adcea88.camel@yandex.ru> <837dwb3zb6.fsf@gnu.org> <20200613141653.GA55972@breton.holly.idiocy.org> <835zbv3v6q.fsf@gnu.org> <20200613142329.GA56313@breton.holly.idiocy.org> <834krf3uij.fsf@gnu.org> <87r1ujatv4.fsf@igel.home> <831rmj3stn.fsf@gnu.org> <87mu57atav.fsf@igel.home> <87lfkpcn6t.fsf_-_@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="59933"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stefan@marxist.se, alan@idiocy.org, emacs-devel@gnu.org, schwab@linux-m68k.org, hi-angel@yandex.ru To: =?iso-8859-1?Q?K=E9vin?= Le Gouguec Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 15 04:38:01 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jkf0b-000FTt-0e for ged-emacs-devel@m.gmane-mx.org; Mon, 15 Jun 2020 04:38:01 +0200 Original-Received: from localhost ([::1]:60728 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkf0Z-0000m6-Uh for ged-emacs-devel@m.gmane-mx.org; Sun, 14 Jun 2020 22:37:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38934) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkezz-0000LY-8P for emacs-devel@gnu.org; Sun, 14 Jun 2020 22:37:23 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57151) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkezv-0005zh-QS; Sun, 14 Jun 2020 22:37:19 -0400 Original-Received: from [176.228.60.248] (port=3668 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jkezv-0004BM-8z; Sun, 14 Jun 2020 22:37:19 -0400 In-Reply-To: <87lfkpcn6t.fsf_-_@gmail.com> (message from =?iso-8859-1?Q?K?= =?iso-8859-1?Q?=E9vin?= Le Gouguec on Mon, 15 Jun 2020 00:11:38 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252254 Archived-At: > From: Kévin Le Gouguec > Cc: Eli Zaretskii , alan@idiocy.org, hi-angel@yandex.ru, > stefan@marxist.se, emacs-devel@gnu.org > Date: Mon, 15 Jun 2020 00:11:38 +0200 > > As Konstantin said, the patch[1] was sent with git send-email, which > allows the sender to "annotate" the patch with some text that will be > ignored by git am (IIUC merely by virtue of being stuck between "---\n" > and the actual diff). > > In Gnus, piping the whole mail to "cd path/to/emacs && git am" (hitting > "|" in the summary buffer) mostly does TRT: the patch is applied, with > the email's subject as commit summary, and the rest of the message (up > to "---\n") completing the commit message. > > The only issue, AFAICT, is that git am fails to strip away the [PATCH] > prefix; IUUC this is because it does not expect debbugs's own "bug#NNN" > prefix. > > > Feel free to dismiss this as armchair commentary, but I think that we're > likely to see more and more patches sent with git send-email[2], since > it is heavily promoted by other projects privileging mail-based > workflows[3]. We accept and welcome patches in any form and shape. However, we recommend to use "git format-patch" (see CONTRIBUTE), and for a good reason: doing so leaves no doubt regarding the authorship of the changes. Whereas just sending email could dupe us in attributing the change to a different person, something that we try to avoid. Of course, with enough manual work and using various Git optional switches, any problem can be worked around, for the price of more time invested. This is why I generally comment on patches sent in forms other than what is described in CONTRIBUTE. Eventually, that is our main contribution document, and we should either stick to what it says or change the document.