From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Changes for emacs 28 Date: Sun, 13 Sep 2020 22:28:17 +0300 Message-ID: <83d02pbhny.fsf@gnu.org> References: <87mu1xrjqw.fsf@gkayaalp.com> <48ed4897-356c-4669-a330-1fdb5d65402b@default> <83lfhhijbl.fsf@gnu.org> <871rj9uz12.fsf@gkayaalp.com> <875z8k4wv8.fsf@posteo.net> <83pn6shjni.fsf@gnu.org> <20200911074445.GB5194@tuxteam.de> <87zh5uqdqm.fsf@mail.linkov.net> <834ko1da33.fsf@gnu.org> <87sgbloe5z.fsf@mail.linkov.net> <83een5bkja.fsf@gnu.org> <87v9ghlc5c.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36872"; mail-complaints-to="usenet@ciao.gmane.io" Cc: tomas@tuxteam.de, emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 13 21:29:05 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHXgO-0009S6-Cy for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Sep 2020 21:29:04 +0200 Original-Received: from localhost ([::1]:43758 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHXgN-0006q6-Fa for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Sep 2020 15:29:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60762) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHXfg-00062S-AN for emacs-devel@gnu.org; Sun, 13 Sep 2020 15:28:20 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35391) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHXfe-0007uA-SJ; Sun, 13 Sep 2020 15:28:18 -0400 Original-Received: from [176.228.60.248] (port=2479 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kHXfc-0001hU-5w; Sun, 13 Sep 2020 15:28:18 -0400 In-Reply-To: <87v9ghlc5c.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 13 Sep 2020 22:17:19 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:255564 Archived-At: > From: Juri Linkov > Cc: tomas@tuxteam.de, emacs-devel@gnu.org > Date: Sun, 13 Sep 2020 22:17:19 +0300 > > >> + (tool-bar-add-item "newsticker/narrow" > > > > This doesn't exactly look like a Hamburger menu icon... > > Really? Maybe someone could help to draw a real hamburger. You need 3 lines, not 4, for starters. > > Also, we'd like to have this at the right edge of the tool bar, where > > users will expect it, I think. > > IDK, some programs display it on the left, some on the right. But not in the middle, I presume? > Anyway, there is a bug in tool-bar code that doesn't allow to use > align-to, whereas align-to works perfectly when used on the tab-bar. > > Here is the test case to reproduce the bug on the tool-bar: > > emacs -Q and eval: > > (define-key-after (default-value 'tool-bar-map) [global-menu-bar] > `(menu-item (propertize " " 'display '(space :align-to (- right 5))) > (lambda () > (interactive) > (popup-menu (mouse-menu-bar-map))) > :image ,(tool-bar--image-expression "newsticker/narrow") > :help "Pop up the global menu bar")) > (force-mode-line-update) > > It doesn't align the icon to the right edge of the tool-bar > whereas the same code aligns it on the tab-bar. Here, the above displays nothing at all on the tool bar.