From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: feature/icomplete-vertical Date: Mon, 05 Oct 2020 15:33:26 +0300 Message-ID: <83d01wdf8p.fsf@gnu.org> References: <20200920130435.heye7bk73pm252km@Ergus> <83sgbczj0i.fsf@gnu.org> <83lfh4zfml.fsf@gnu.org> <838sd4z6lz.fsf@gnu.org> <20201001164804.mqqyxtet4ttweuyv@Ergus> <83blhhdy3w.fsf@gnu.org> <87d01xghmt.fsf@gmail.com> <83sgatc8er.fsf@gnu.org> <83mu11c78j.fsf@gnu.org> <87tuv9eygk.fsf@gmail.com> <87imbogb6k.fsf@gmail.com> <83eemcdgg2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27519"; mail-complaints-to="usenet@ciao.gmane.io" Cc: joaotavora@gmail.com, spacibba@aol.com, juri@linkov.net, casouri@gmail.com, emacs-devel@gnu.org To: Gregory Heytings Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 05 14:36:48 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kPPjU-00073s-Ln for ged-emacs-devel@m.gmane-mx.org; Mon, 05 Oct 2020 14:36:48 +0200 Original-Received: from localhost ([::1]:51476 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kPPjT-0001yh-Nz for ged-emacs-devel@m.gmane-mx.org; Mon, 05 Oct 2020 08:36:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34618) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPPgG-0000GB-Up for emacs-devel@gnu.org; Mon, 05 Oct 2020 08:33:34 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57801) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kPPgF-0006Vw-Fc; Mon, 05 Oct 2020 08:33:27 -0400 Original-Received: from [176.228.60.248] (port=1504 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kPPgE-0005K6-Br; Mon, 05 Oct 2020 08:33:27 -0400 In-Reply-To: (message from Gregory Heytings on Mon, 05 Oct 2020 12:25:13 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:257121 Archived-At: > Date: Mon, 05 Oct 2020 12:25:13 +0000 > From: Gregory Heytings > cc: spacibba@aol.com, emacs-devel@gnu.org, casouri@gmail.com, > joaotavora@gmail.com, juri@linkov.net > > > No, my objections are that your proposal is not safe wrt recursive > > editing, and will affect uses of mini-windows other than prompting the > > user, where these effects aren't intended. > > > > AFAIU, Stefan agreed that this is a problem in your proposal. > > > > I don't know which proposal you refer to in that sentence, but I guess > it's the (second) patch I sent on bug#43572 a week ago, against Emacs C > core. I referred to the same proposal to which Joćo referred. > The solution in this thread works at the Lisp level, and will not affect > other uses of the miniwindow, because it relies on a minibuffer-local > variable. AFAICS it is also safe wrt recursive editing. Using a buffer-local variable doesn't necessarily eliminate the problems with recursive-edit. And using window-scroll-functions for this purpose is a no-no. So I cannot endorse this others solution, either.