From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH v2 01/16] Add a test for let-binding unwinding
Date: Tue, 01 Dec 2020 18:44:17 +0200
Message-ID: <83czztiihq.fsf@gnu.org>
References: <20201119153814.17541-1-sbaugh@catern.com>
 <cover.1606009917.git.sbaugh@catern.com>
 <b9b9479699729aaeb98b7280699d7f1e291322d8.1606009917.git.sbaugh@catern.com>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="18862"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: sbaugh@catern.com, arnold@tdrhq.com, dgutov@yandex.ru,
 monnier@iro.umontreal.ca, emacs-devel@gnu.org
To: Spencer Baugh <sbaugh@catern.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 01 17:45:21 2020
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1kk8mG-0004mw-K0
	for ged-emacs-devel@m.gmane-mx.org; Tue, 01 Dec 2020 17:45:20 +0100
Original-Received: from localhost ([::1]:56198 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1kk8mF-0007w8-LV
	for ged-emacs-devel@m.gmane-mx.org; Tue, 01 Dec 2020 11:45:19 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55030)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1kk8lN-0007QR-Cj
 for emacs-devel@gnu.org; Tue, 01 Dec 2020 11:44:25 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58178)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1kk8lM-0000tq-Ab; Tue, 01 Dec 2020 11:44:24 -0500
Original-Received: from [176.228.60.248] (port=1572 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1kk8lL-0006r0-O7; Tue, 01 Dec 2020 11:44:24 -0500
In-Reply-To: <b9b9479699729aaeb98b7280699d7f1e291322d8.1606009917.git.sbaugh@catern.com>
 (message from Spencer Baugh on Sat, 21 Nov 2020 21:34:30 -0500)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:260135
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/260135>

> From: Spencer Baugh <sbaugh@catern.com>
> Date: Sat, 21 Nov 2020 21:34:30 -0500
> Cc: Spencer Baugh <sbaugh@catern.com>, Arnold Noronha <arnold@tdrhq.com>,
>  Stefan Monnier <monnier@iro.umontreal.ca>, Dmitry Gutov <dgutov@yandex.ru>
> 
> Bindings in other buffers are not un-set when we unwind a let-binding
> which set the default value.  There doesn't seem to be an existing
> test which covers this, so here's one.

This is okay, but please accompany the change with a ChangeLog-style
commit log message (see CONTRIBUTE for details and the existing log
messages for examples).

Thanks.