From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Stop frames stealing eachothers' minibuffers! Date: Wed, 17 Mar 2021 21:55:38 +0200 Message-ID: <83czvxd079.fsf@gnu.org> References: <874kinakv2.fsf@miha-pc> <87sg6690vc.fsf@miha-pc> <87pn02ojwu.fsf@miha-pc> <875z1tfn0p.fsf@miha-pc> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28697"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, jakanakaevangeli@chiru.no, emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 17 20:56:28 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lMcHL-0007Nu-Do for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Mar 2021 20:56:27 +0100 Original-Received: from localhost ([::1]:55496 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMcHJ-00015j-Ud for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Mar 2021 15:56:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59974) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMcGe-0000e9-3D for emacs-devel@gnu.org; Wed, 17 Mar 2021 15:55:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42474) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMcGc-0002Gv-7q; Wed, 17 Mar 2021 15:55:42 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2089 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lMcGa-0003DL-Gi; Wed, 17 Mar 2021 15:55:41 -0400 In-Reply-To: (message from Alan Mackenzie on Wed, 17 Mar 2021 19:32:37 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266530 Archived-At: > Date: Wed, 17 Mar 2021 19:32:37 +0000 > From: Alan Mackenzie > Cc: Stefan Monnier , emacs-devel@gnu.org > > > When a frame is closed, it's active minibuffer should now be moved to > > another frame. What I wanted to test then was, what happens if we have > > only a single frame with a minibuffer and we decide to close it, which > > is possible with emacs daemon. Immediately, there will be no frames left > > for the minibuffer to take refuge in and this seems to cause some > > problems. > > My apologies. I hadn't understood what the bug is, and can confirm it's > still there. My patch below doesn't address it. > > This could be difficult to fix. I don't think that clicking on the last > frame's close button goes through `delete-frame' - it just closes the > program, whether that's emacs or emacsclient. I'm not sure I understand completely what you say here, but clicking on the frame's close button does invoke delete-frame, see the handling of DELETE_FRAME_EVENT in keyboard.c.