From: Eli Zaretskii <eliz@gnu.org>
To: tumashu <tumashu@163.com>
Cc: emacs-devel@gnu.org
Subject: Re: [patch] * lisp/international/mule-cmds.el (deactivate-input-method): Tiny improve.
Date: Wed, 28 Apr 2021 18:03:10 +0300 [thread overview]
Message-ID: <83czuefo41.fsf@gnu.org> (raw)
In-Reply-To: <4a8e0cd2.61de.17918783c9d.Coremail.tumashu@163.com> (message from tumashu on Wed, 28 Apr 2021 20:33:23 +0800 (CST))
> Date: Wed, 28 Apr 2021 20:33:23 +0800 (CST)
> From: tumashu <tumashu@163.com>
> Cc: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
>
> >> - (funcall deactivate-current-input-method-function))
> >> + (when (functionp deactivate-current-input-method-function)
> >> + (funcall deactivate-current-input-method-function)))
> >
> >Thanks, but could you please explain why this is needed? IOW, in
> >which use case did you see this function called when
> >deactivate-current-input-method-function wasn't a function?
>
> Yes, I have faced some bugs of pyim in evil environment, sometimes, this variable maybe is nil.
> I can not find why.
I see traces of using defadvise there. Could it be that the advice
calls deactivate-input-method incorrectly?
next prev parent reply other threads:[~2021-04-28 15:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 7:24 [patch] * lisp/international/mule-cmds.el (deactivate-input-method): Tiny improve tumashu
2021-04-28 11:54 ` Eli Zaretskii
2021-04-28 12:33 ` tumashu
2021-04-28 15:03 ` Eli Zaretskii [this message]
2021-04-28 22:37 ` tumashu
2021-05-08 9:54 ` tumashu
2021-05-08 14:02 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83czuefo41.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=tumashu@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).