From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Small shell-mode patch to handle auto-cd (e.g. shells like zsh) Date: Sat, 15 May 2021 11:20:11 +0300 Message-ID: <83cztsxvb8.fsf@gnu.org> References: <83v97we0ey.fsf@gnu.org> <6cb49320-ca9e-9212-13c8-78aa0a4f7dde@icloud.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22747"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jason.kim@revtera.com, michael.albinus@gmx.de, shivers@cs.cmu.edu, emacs-devel@gnu.org To: Jason Kim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 15 10:21:08 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lhpXo-0005iv-J5 for ged-emacs-devel@m.gmane-mx.org; Sat, 15 May 2021 10:21:08 +0200 Original-Received: from localhost ([::1]:53562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhpXn-0006lP-Kl for ged-emacs-devel@m.gmane-mx.org; Sat, 15 May 2021 04:21:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47410) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhpWz-0003tV-Vi for emacs-devel@gnu.org; Sat, 15 May 2021 04:20:18 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37642) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhpWx-00087i-RY; Sat, 15 May 2021 04:20:15 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1247 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhpWw-0005Rp-CI; Sat, 15 May 2021 04:20:15 -0400 In-Reply-To: <6cb49320-ca9e-9212-13c8-78aa0a4f7dde@icloud.com> (message from Jason Kim on Fri, 7 May 2021 09:51:08 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269303 Archived-At: > Cc: emacs-devel@gnu.org, shivers@cs.cmu.edu, jason.kim@revtera.com > From: Jason Kim > Date: Fri, 7 May 2021 09:51:08 -0700 > > Hi, enclosed is what I hope is an acceptable git-format-patch for this > tiny change. > > If not, please let me know how to fix! Applying these patches produces the following byte-compilation warnings: ELC shell.elc In toplevel form: shell.el:324:1: Warning: defcustom for `shell-has-auto-cd' fails to specify type shell.el:324:1: Warning: custom-declare-variable `shell-has-auto-cd' docstring wider than 80 characters In addition, please provide a :version tag for the new defcustom. And finally, the commit log message should include ChangeLog-style description of the file(s) and functions/variables which were affected by the changes, see the existing log messages and the advice in CONTRIBUTE for more details. Please fix those minor nits, and then we will be able to install the changes. Thanks.