From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master e37eb7f: Add support for pixel wheel deltas on NS Date: Sun, 28 Nov 2021 09:53:38 +0200 Message-ID: <83czmkyav1.fsf@gnu.org> References: <20211125030922.2353.1129@vcs0.savannah.gnu.org> <20211125030924.7258E2094B@vcs0.savannah.gnu.org> <871r34h6pi.fsf@gmail.com> <87fsrkzfq1.fsf@yahoo.com> <83tug05whz.fsf@gnu.org> <87tufzycli.fsf@yahoo.com> <837dcv4e79.fsf@gnu.org> <87wnkvflk7.fsf@yahoo.com> <83zgpr2uvr.fsf@gnu.org> <87fsrjfeb1.fsf@yahoo.com> <83r1b32lvr.fsf@gnu.org> <83pmqn2l3s.fsf@gnu.org> <8735njf7gz.fsf@yahoo.com> <83mtlr2jhw.fsf@gnu.org> <87tufzdrez.fsf@yahoo.com> <87o8657zx9.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14657"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rpluim@gmail.com, emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 28 08:54:34 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mrF18-0003cC-06 for ged-emacs-devel@m.gmane-mx.org; Sun, 28 Nov 2021 08:54:34 +0100 Original-Received: from localhost ([::1]:55798 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mrF15-0003Z4-HD for ged-emacs-devel@m.gmane-mx.org; Sun, 28 Nov 2021 02:54:32 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37752) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrF04-0002IM-So for emacs-devel@gnu.org; Sun, 28 Nov 2021 02:53:29 -0500 Original-Received: from [2001:470:142:3::e] (port=55048 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrF04-0006So-GA; Sun, 28 Nov 2021 02:53:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=kcedxQZSPoN9XlyWbaUWDuyeFAFGjVo5b5IKeNf1o+g=; b=EA0MrTMpDy6X aZtHZdZs7W/DWYoceLB/UztRrQhcVZOm+shZVFZ9kGuJZL8FYnm8ER+Pe4yFRZJVT6Y1LaYe2v0Ay PMkcZB5zQQ0k1zKXda0w+uaQruUHn6A+Wz3xlIOgvFWnBMI+qLpQT2gNTuKGz2xWQObU/LMpkFe1l YzexqRv5gtDnGt+xGkExpe+rZ/4iTwVPWiPfuX8pXnL+JawsE3cEJfswj7m9eFNQWZut9Wzza6MNO 7/CQ70aquzNinUmZxLHmPfSuCCyT9zDZoK7DbUBiX4/1d7CrzK3DC68kqTyhNAovQ31TfMi2khDd2 cG2ZTJ+2G7X6gjzpt9VIOg==; Original-Received: from [87.69.77.57] (port=1705 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrF04-0001P2-7O; Sun, 28 Nov 2021 02:53:28 -0500 In-Reply-To: <87o8657zx9.fsf@yahoo.com> (message from Po Lu on Sun, 28 Nov 2021 10:54:26 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280379 Archived-At: > From: Po Lu > Cc: rpluim@gmail.com, emacs-devel@gnu.org > Date: Sun, 28 Nov 2021 10:54:26 +0800 > > Po Lu writes: > > > Eli Zaretskii writes: > > > >> It's simple: we could provide a variable to scale the pixels > >> calculated by the *term code. > > > > Alternatively, how about putting such an option in the code that makes > > use of such events, something like `pixel-scroll-precision-scale'. > > diff --git a/lisp/pixel-scroll.el b/lisp/pixel-scroll.el > index 888320cf1a..a14c211207 100644 > --- a/lisp/pixel-scroll.el > +++ b/lisp/pixel-scroll.el > @@ -100,6 +100,11 @@ pixel-scroll-precision-mode-map > map) > "The key map used by `pixel-scroll-precision-mode'.") > > +(defcustom pixel-scroll-precision-scale 1.0 > + "Value by which to multiply pixel deltas used in `pixel-scroll-precision-mode'." > + :type 'float > + :group 'mouse) > + I think this factor should not be specific to pixel-scroll.el, it should be applied by keyboard.c where it constructs the event, or maybe by the *term.[cm] terminal-specific backends.