From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix bookmark-bmenu-list sorting. Date: Fri, 04 Mar 2022 13:46:36 +0200 Message-ID: <83czj2hrdv.fsf@gnu.org> References: <875yovm1m6.fsf@elite.giraud> <87v8wvkk64.fsf@red-bean.com> <83v8wuj3v0.fsf@gnu.org> <87tucewgu7.fsf@red-bean.com> <83lexqi3z9.fsf@gnu.org> <87tuceuo4b.fsf@red-bean.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27326"; mail-complaints-to="usenet@ciao.gmane.io" Cc: manuel@ledu-giraud.fr, emacs-devel@gnu.org To: Karl Fogel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 04 12:47:38 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nQ6PK-0006uV-Ai for ged-emacs-devel@m.gmane-mx.org; Fri, 04 Mar 2022 12:47:38 +0100 Original-Received: from localhost ([::1]:60550 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nQ6PI-0002lj-Rz for ged-emacs-devel@m.gmane-mx.org; Fri, 04 Mar 2022 06:47:36 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59894) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQ6OL-00025C-7K for emacs-devel@gnu.org; Fri, 04 Mar 2022 06:46:37 -0500 Original-Received: from [2001:470:142:3::e] (port=57392 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQ6OK-0002vM-Cj; Fri, 04 Mar 2022 06:46:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=241RX6NgonHAcPACR2mF9pLnnVMt38ac4j/3fQBK2ac=; b=r8DJr7I+g7ev Q4nQbODDxJDFTfgj69kNmDMD4cXcdEeV1qK7flCOZeLDerHaqQ4TYMWoT3sSW4njivyo9Kt4wjpQr dvuzluAHCZp8LoJGrST01ycr0vvVEa8Lj65WLEg9MyyFnn9srVOWw+wM4WWc2hkEPnyDNcv9c59m7 6iTurgP0jpGhNBVngNIKvApGGVgWBXjTmCpuEhNPJ2QHyx1Ya72Se50tRZ/+YQIKbgs38aEK2R/Vh /O1jd9+WgYjP9A4wSXpGl+3rXwNh8PGnF180zwHMt6XqhZjypm7KqFVtLzeKX5nvw/u9tCIm2eoJf dALC7jbKeiEeYWNFyPN/qg==; Original-Received: from [87.69.77.57] (port=2660 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQ6OJ-0001wd-O0; Fri, 04 Mar 2022 06:46:36 -0500 In-Reply-To: <87tuceuo4b.fsf@red-bean.com> (message from Karl Fogel on Fri, 04 Mar 2022 02:18:44 -0600) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286814 Archived-At: > From: Karl Fogel > Cc: manuel@ledu-giraud.fr, emacs-devel@gnu.org > Date: Fri, 04 Mar 2022 02:18:44 -0600 > > On 04 Mar 2022, Eli Zaretskii wrote: > >The original message didn't describe any bugs, so I concluded it > >was a > >new feature. Sorry about that. > > > >However, if this is a bug, please tell: > > > > . what is the bug and how to reproduce it? > > . if this is a regression, what was the last Emacs version > > where the > > reproduction recipe worked correctly? > > The variable `bookmark-sort-flag' is not obeyed in > `bookmark-bmenu-mode' (that's the Dired-like mode entered > interactively via `edit-bookmarks'). But it _is_ obeyed in other places in bookmark.el, including in bookmark-bmenu--revert (and thus in its callers). So it isn't like this variable is not obeyed at all, it's just that there seem to be some specific situations where it isn't. And you didn't answer my second question (and neither did Manuel). Knowing whether this is a recent regression or not is important for the decision whether to fix it now or later.