unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: larsi@gnus.org, emacs-devel@gnu.org
Subject: Re: master f8bb6cca33: Return the same file from locate-file in nativecomp and non
Date: Mon, 14 Mar 2022 16:29:10 +0200	[thread overview]
Message-ID: <83cziok3pl.fsf@gnu.org> (raw)
In-Reply-To: <jwvczipgzqt.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Sun, 13 Mar 2022 20:20:38 -0400)

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: larsi@gnus.org,  emacs-devel@gnu.org
> Date: Sun, 13 Mar 2022 20:20:38 -0400
> 
> >> AFAIK it reverts the behavior of `locate-file-internal` to that of
> >> Emacs-27
> > Emacs 27 behavior cannot guide us here, because the *.eln files and
> > the aspects they bring into the issue are new.
> 
> `locate-file` is a function looks for files with a given set of
> extensions through path.  That's it.  Nothing specific to ELisp files.
> E.g. it's used in `executable-find`.
> 
> The existence of `.eln` should have no bearing on this.

Are you sure?  We never discussed this seriously.

E.g., is the result below expected, or is it a bug?

  (locate-file "simple" native-comp-eln-load-path '(".eln"))
    => nil

Or what about load-history -- why does it only show the *.elc files
loaded by the session, but not the *.eln files?  Should it?  (This
discussion was triggered by a conflict between load-history and
locate-file, so load-history is definitely relevant to the issue at
hand.)

> It can affect the ELisp-specific code (such as `load` or
> `find-library`), which may indeed use `locate-file` internally, but it
> should not affect `locate-file` itself.

It didn't until now.  But one can argue that it was only so because
the .el and its .elc file usually live in the same directory and have
the same basename.  That is no longer true with *.eln files, so we
should perhaps stop and think about this a bit harder.  E.g., maybe a
simpleton that locate-file is no longer satisfies us for looking up
Lisp files?

> >> so I'd even suggest we install my patch in `emacs-28`.
> > Do we want to release Emacs 28 any time soon, or do we want to
> > continue dragging our feet by making destabilizing changes in it?
> 
> Notice that I did not install it on `emacs-28` nor asked to do that.

Is there such a big difference between "ask" (which you didn't) and
"would suggest" (which you did)?



  reply	other threads:[~2022-03-14 14:29 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <164712074096.14747.18124931770043811100@vcs2.savannah.gnu.org>
     [not found] ` <20220312213221.451B3C01684@vcs2.savannah.gnu.org>
2022-03-12 21:47   ` master f8bb6cca33: Return the same file from locate-file in nativecomp and non Stefan Monnier
2022-03-12 21:51     ` Lars Ingebrigtsen
2022-03-12 23:23       ` Stefan Monnier
2022-03-12 23:40         ` Lars Ingebrigtsen
2022-03-13  4:51           ` Stefan Monnier
2022-03-13  6:01             ` Eli Zaretskii
2022-03-13 14:16               ` Lars Ingebrigtsen
2022-03-13 14:26                 ` Stefan Monnier
2022-03-13 14:40                   ` Lars Ingebrigtsen
2022-03-13 17:15                   ` Eli Zaretskii
2022-03-14  0:20                     ` Stefan Monnier
2022-03-14 14:29                       ` Eli Zaretskii [this message]
2022-03-14 16:57                         ` Stefan Monnier
2022-03-14 17:22                           ` Eli Zaretskii
2022-03-14 18:09                             ` Stefan Monnier
2022-03-14 22:29                               ` Corwin Brust
2022-03-15 13:11                                 ` Stefan Monnier
2022-03-13 16:59                 ` Eli Zaretskii
2022-03-13 22:16                   ` Lars Ingebrigtsen
2022-03-14  3:26                     ` Eli Zaretskii
2022-03-14  2:57                   ` Stefan Monnier
2022-03-14  3:38                     ` Eli Zaretskii
2022-03-14  4:04                       ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83cziok3pl.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).