From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master c3ab8f1: Improve buffer-match-p documentation Date: Sat, 16 Apr 2022 11:40:53 +0300 Message-ID: <83czhh1kve.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18441"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 16 10:43:22 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nfe1Z-0004gZ-BA for ged-emacs-devel@m.gmane-mx.org; Sat, 16 Apr 2022 10:43:21 +0200 Original-Received: from localhost ([::1]:41296 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nfe1X-0005YP-Tj for ged-emacs-devel@m.gmane-mx.org; Sat, 16 Apr 2022 04:43:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53586) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nfdz5-0003bo-04 for emacs-devel@gnu.org; Sat, 16 Apr 2022 04:40:47 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58016) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nfdyw-0007XP-NT; Sat, 16 Apr 2022 04:40:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Subject:To:From:Date:mime-version:in-reply-to: references; bh=eqFz3oewFBheulFQpZYHK9B2irpE9dEbu1umq4Uql9s=; b=OMSiWKGjBZTsCu sseoBrHQh0+oALCL15gwRk+C/OlNz173i93IzB8aqy5Nua/BkDg+kN6w75sMvH4+kuNnjWhyY4R1Y 6gVP9/UYdsR6dfdKIgaJQqutZVtzNfPvpi672B/sfU/A3ZfCDTknVqM2+XxnkqW3JAxE23+dt221p /zINzni/t7rHt8eQNFsL1bjlSNY+DCoCxycslFX+XxMh0wCu1iYG3u/MRyVZtN25bQZxKQ3UdP9vs kLn037gVUFysj7ydHiKwLQX2LKIUgJujpNAU0ZOq2AIx/bBmYdIJ/GOSZNCI97iT0Y9qS54OC4pKx kDTU9VOGppfD+LKdnH5Q==; Original-Received: from [87.69.77.57] (port=2663 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nfdyv-0003Ui-P3; Sat, 16 Apr 2022 04:40:38 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288474 Archived-At: > diff --git a/lisp/window.el b/lisp/window.el > index 2da2f8b..ea90995 100644 > --- a/lisp/window.el > +++ b/lisp/window.el > @@ -7495,14 +7495,14 @@ display-buffer-fallback-action > `display-buffer'.") > (put 'display-buffer-fallback-action 'risky-local-variable t) > > -(defun display-buffer-assq-regexp (buffer-name alist action) > +(defun display-buffer-assq-regexp (buffer-or-name alist action) > "Retrieve ALIST entry corresponding to BUFFER-NAME. > -This returns the cdr of the alist entry ALIST if either its key > -satisfied a BUFFER-NAME per `buffer-match'. ACTION should have > -the form of the action argument passed to `display-buffer'." > +This returns the cdr of the alist entry ALIST if key and > +buffer-or-name satisfy `buffer-match-p'. ACTION should have the > +form of the action argument passed to `display-buffer'." I fixed some minor issues with the modified doc string, but that still leaves one question unanswered: what does this function return if no alist entry satisfies buffer-match-p? That should be documented. Thanks.