unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: larsi@gnus.org, malsburg@posteo.de, emacs-devel@gnu.org
Subject: Re: master 91418d27e9: Add new functions for computing character metrics for windows
Date: Fri, 29 Apr 2022 22:59:11 +0300	[thread overview]
Message-ID: <83czgzacfk.fsf@gnu.org> (raw)
In-Reply-To: <jwvpml0dkhh.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Fri, 29 Apr 2022 10:55:09 -0400)

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Titus von der Malsburg <malsburg@posteo.de>,  emacs-devel@gnu.org
> Date: Fri, 29 Apr 2022 10:55:09 -0400
> 
> So, really it's just another variant of `window-body-width`?

Not really, no.

> Could we use a name that's "closer" then?

Please suggest a better name.

> We should try and "bring together" all the window-foo-width variants so
> as to try and reduce the probability that someone uses the wrong one by
> accident.

The latter part is impossible.  Most Lisp programmers don't understand
the fine details and issues with different measures of "window-width",
and it's infeasible to teach them all that complexity.

> Not completely sure what "bring together" should mean here.  Could be
> merge them into a single function with an extra argument describing
> which elements to include/exclude in the count, or it could be to place
> them all under the `window-width-` prefix, or includes links
> between them in their docstrings, ...
> And of course clearly describe the differences between them.

IMNSHO, that way lies madness.  There are too many variations and too
many special cases.

> Maybe in this case, instead of introducing a new function we should
> refine the "pixelwise" arg of `window-body-width` so we can choose
> between pixelwise, or based on the size of the frame's font, or based on
> the size of a particular face's font?

Why does it make sense to complicate a single API instead of having N
simpler APIs that do the different jobs?  What practical problem will
this solve?



  reply	other threads:[~2022-04-29 19:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <165123811050.20687.5215165731843845332@vcs2.savannah.gnu.org>
     [not found] ` <20220429131511.9BD62C01683@vcs2.savannah.gnu.org>
2022-04-29 13:46   ` master 91418d27e9: Add new functions for computing character metrics for windows Stefan Monnier
2022-04-29 13:53     ` Lars Ingebrigtsen
2022-04-29 14:55       ` Stefan Monnier
2022-04-29 19:59         ` Eli Zaretskii [this message]
2022-04-29 20:40           ` Stefan Monnier
2022-04-30  5:23             ` Eli Zaretskii
2022-04-30 11:12             ` Lars Ingebrigtsen
2022-04-30 13:33               ` Stefan Monnier
2022-04-30 13:48                 ` Eli Zaretskii
2022-04-30 14:34                   ` Stefan Monnier
2022-04-30 15:25                     ` Eli Zaretskii
2022-04-30 15:52                       ` Stefan Monnier
2022-04-30 16:19                         ` Eli Zaretskii
2022-04-30 21:47                           ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83czgzacfk.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    --cc=malsburg@posteo.de \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).