unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: master 2f31dbeadf: Also show mouse DND tooltip contents during interprogram drag-and-drop
Date: Thu, 09 Jun 2022 10:03:27 +0300	[thread overview]
Message-ID: <83czfi48u8.fsf@gnu.org> (raw)

> branch: master
> commit 2f31dbeadff0abc38ded5dd072df1ec179c49945
> Author: Po Lu <luangruo@yahoo.com>
> Commit: Po Lu <luangruo@yahoo.com>
> 
>     Also show mouse DND tooltip contents during interprogram drag-and-drop
>     
>     * doc/lispref/frames.texi (Drag and Drop): Document new
>     parameter to `x-begin-drag'.
>     * lisp/mouse.el (mouse-drag-and-drop-region): Don't hide tooltip
>     when initiating interprogram drag-and-drop.
>     * lisp/term/haiku-win.el (x-begin-drag):
>     * lisp/term/ns-win.el (x-begin-drag): Add stubs for new
>     parameter.
>     * src/xfns.c (Fx_begin_drag): New parameter `follow-tooltip'.
>     (Fx_show_tip, syms_of_xfns): Add records of the last dx and dy
>     given to `x-show-tip'.
>     * src/xterm.c (x_clear_dnd_monitors): New function.
>     (x_dnd_begin_drag_and_drop): Save monitor attributes list if
>     appropriate.
>     (x_dnd_compute_tip_xy, x_dnd_update_tooltip_position): New
>     function.
>     (x_dnd_update_state, handle_one_xevent): Update tooltip position
>     during DND mouse movement.
>     (syms_of_xterm): Update staticpros.
>     * src/xterm.h: Update prototypes.

Instead of recording tooltip's coordinates in static C variables
(which then could cause potential problems with stale values),
wouldn't it be better to just move the tip frame from Lisp when the
mouse moves?



             reply	other threads:[~2022-06-09  7:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-09  7:03 Eli Zaretskii [this message]
2022-06-09  7:50 ` master 2f31dbeadf: Also show mouse DND tooltip contents during interprogram drag-and-drop Po Lu
2022-06-09  9:18   ` Eli Zaretskii
2022-06-09 10:07     ` Po Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83czfi48u8.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).