From: Eli Zaretskii <eliz@gnu.org>
To: michael.albinus@gmx.de
Cc: emacs-devel@gnu.org
Subject: Re: emacs-29 bdb0bc2b4e4: Fix tex-mode display-buffer issues
Date: Mon, 12 Jun 2023 16:25:29 +0300 [thread overview]
Message-ID: <83cz20yfqu.fsf@gnu.org> (raw)
In-Reply-To: <83edmgygew.fsf@gnu.org> (message from Eli Zaretskii on Mon, 12 Jun 2023 16:11:03 +0300)
> Date: Mon, 12 Jun 2023 16:11:03 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: emacs-devel@gnu.org
>
> Sorry, I have no idea what this failure means. In particular, the
> value is correct for the defcustom, and works in practice, and also
> fits the type of the defcustom (AFAICT).
>
> The checks that cus-test.el does are not documented in any meaningful
> way, and its output is not useful. I didn't even know we had such a
> test, and never ran it myself.
Btw, running "make test-custom-opts" in test/ gives me a different
error:
make[1]: Entering directory `/d/gnu/git/emacs/branch/test'
Running 1 tests (2023-06-12 16:19:27+0300, selector `(not (or (tag :unstable) (tag :nativecomp)))')
Loading d:/gnu/git/emacs/branch/admin/cus-test.el (source)...
Running cus-test-load-libs
Finding files...
Test check-for-wrong-custom-opts backtrace:
signal(error ("find exited with status 1"))
apply(signal (error ("find exited with status 1")))
(setq value-7 (apply fn-5 args-6))
(unwind-protect (setq value-7 (apply fn-5 args-6)) (setq form-descri
(if (unwind-protect (setq value-7 (apply fn-5 args-6)) (setq form-de
(let (form-description-9) (if (unwind-protect (setq value-7 (apply f
(let ((value-7 'ert-form-evaluation-aborted-8)) (let (form-descripti
(let* ((fn-5 #'null) (args-6 (condition-case err (let ((signal-hook-
(closure (t) nil (let* ((fn-0 #'file-readable-p) (args-1 (condition-
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name check-for-wrong-custom-opts :document
ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :unstabl
ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
command-line-1(("-L" ";." "-l" "ert" "-l" "misc/test-custom-opts.el"
command-line()
normal-top-level()
Test check-for-wrong-custom-opts condition:
(error "find exited with status 1")
FAILED 1/1 check-for-wrong-custom-opts (0.406250 sec) at misc/test-custom-opts.el:33
Ran 1 tests, 0 results as expected, 1 unexpected (2023-06-12 16:19:28+0300, 1.453125 sec)
1 unexpected results:
FAILED check-for-wrong-custom-opts
So there's more to this than meets the eye, and some code (but which
one?) which runs 'find' is probably doing that in a non-portable
fashion. (I needed to run admin/cus-tests.el by hand to get the error
which you quote.)
next prev parent reply other threads:[~2023-06-12 13:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <168646413703.30014.174311348729871734@vcs2.savannah.gnu.org>
[not found] ` <20230611061539.9CBD6C1925C@vcs2.savannah.gnu.org>
2023-06-12 12:21 ` emacs-29 bdb0bc2b4e4: Fix tex-mode display-buffer issues Michael Albinus
2023-06-12 13:11 ` Eli Zaretskii
2023-06-12 13:25 ` Eli Zaretskii [this message]
2023-06-12 14:01 ` Robert Pluim
2023-06-12 14:35 ` Eli Zaretskii
2023-06-12 15:57 ` Robert Pluim
2023-06-12 16:40 ` Eli Zaretskii
2023-06-12 17:10 ` Robert Pluim
2023-06-12 17:51 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83cz20yfqu.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).