From: Eli Zaretskii <eliz@gnu.org>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: andrewjmoreton@gmail.com, schwab@linux-m68k.org, emacs-devel@gnu.org
Subject: Re: emacs-21.1.94 crash in gnus on Windows
Date: Thu, 25 Mar 2010 21:51:03 +0200 [thread overview]
Message-ID: <83bpecgoyg.fsf@gnu.org> (raw)
In-Reply-To: <87y6hg5phi.fsf@stupidchicken.com>
> From: Chong Yidong <cyd@stupidchicken.com>
> Cc: schwab@linux-m68k.org, andrewjmoreton@gmail.com, emacs-devel@gnu.org
> Date: Thu, 25 Mar 2010 12:35:05 -0400
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > But the part that you left in the code also uses it.glyph_row, which
> > is garbage after a call to move_it_to. There's a single use of
> > it.glyph_row->x before the call to PRODUCE_GLYPHS (&it2), and I think
> > that needs to be fixed as well, because it potentially dereferences a
> > bad pointer.
> >
> > Or did I miss something?
>
> I don't see the failure condition. This branch handles the special case
> of charpos == 1 or charpos above the top of the window. Since
> start_display initialized the iterator using the desired matrix of the
> window, it.glyph_row should always be valid.
>
> Or am I confused?
it.glyph_row is indeed initialized in start_display. But are you sure
it.glyph_row->x is set correctly? move_it_to does not produce glyphs
in glyph_row, so who computes glyph_row->x ?
next prev parent reply other threads:[~2010-03-25 19:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-15 23:40 emacs-21.1.94 crash in gnus on Windows Andy Moreton
2010-03-16 10:33 ` Eli Zaretskii
2010-03-16 12:53 ` Andy Moreton
2010-03-16 15:26 ` David Kastrup
2010-03-16 20:34 ` Andy Moreton
2010-03-16 19:47 ` Eli Zaretskii
2010-03-16 20:42 ` Andy Moreton
2010-03-16 21:49 ` Eli Zaretskii
2010-03-20 12:19 ` Andreas Schwab
2010-03-20 15:45 ` Andreas Schwab
2010-03-20 16:20 ` Eli Zaretskii
2010-03-20 16:24 ` Andreas Schwab
2010-03-20 16:31 ` Eli Zaretskii
2010-03-24 13:50 ` Andy Moreton
2010-03-24 21:34 ` Chong Yidong
2010-03-25 4:14 ` Eli Zaretskii
2010-03-25 16:35 ` Chong Yidong
2010-03-25 19:51 ` Eli Zaretskii [this message]
2010-03-20 16:29 ` Eli Zaretskii
2010-03-20 16:46 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bpecgoyg.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=andrewjmoreton@gmail.com \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).