From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: attribute warn_unused_result Date: Fri, 04 Feb 2011 10:41:32 +0200 Message-ID: <83bp2sb39f.fsf@gnu.org> References: <4D4B02EF.1080708@cs.ucla.edu> <7C616374-F2D6-4797-A66C-9C4D293B93B6@mit.edu> <4D4B20C5.1070100@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1296809256 7631 80.91.229.12 (4 Feb 2011 08:47:36 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 4 Feb 2011 08:47:36 +0000 (UTC) Cc: yandros@MIT.EDU, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 04 09:47:31 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PlHKF-0000ho-Jb for ged-emacs-devel@m.gmane.org; Fri, 04 Feb 2011 09:47:31 +0100 Original-Received: from localhost ([127.0.0.1]:52112 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PlHKE-0002zs-TP for ged-emacs-devel@m.gmane.org; Fri, 04 Feb 2011 03:47:31 -0500 Original-Received: from [140.186.70.92] (port=37321 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PlHEQ-0000Nh-3a for emacs-devel@gnu.org; Fri, 04 Feb 2011 03:41:30 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PlHEO-00009r-RQ for emacs-devel@gnu.org; Fri, 04 Feb 2011 03:41:29 -0500 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:61282) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PlHEO-00009T-Kk for emacs-devel@gnu.org; Fri, 04 Feb 2011 03:41:28 -0500 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LG3007002JH9200@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Fri, 04 Feb 2011 10:41:27 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.124.97.124]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LG3007EQ4506J90@a-mtaout22.012.net.il>; Fri, 04 Feb 2011 10:41:25 +0200 (IST) In-reply-to: <4D4B20C5.1070100@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.172 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:135563 Archived-At: > Date: Thu, 03 Feb 2011 13:40:21 -0800 > From: Paul Eggert > CC: Emacs-Devel devel , Eli Zaretskii > > On 02/03/11 12:42, Chad Brown wrote: > > > ..and it broke the W32 and nextstep builds (at least) again. > > Sorry, I forgot to add the new file lib/ignore-value.h. > That should be fixed now. > > On 02/03/11 13:16, Eli Zaretskii wrote: > > > And is butt-ugly, IMO. > > I don't like ignore-value either. I'd rather that we simply > tell GCC never to generate those bogus warnings anywhere. > However, as I understand it, that's not so easily done. The -Wno-unused-result compiler options looks easy to me, and is IMO cleaner than using ignore-value.h. Heck, even the corresponding pragma in the affected source files looks cleaner. The only advantage of ignore-value.h is that it will work with compilers other than GCC (if some of them also insist on this warning).