unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: yandros@MIT.EDU, emacs-devel@gnu.org
Subject: Re: attribute warn_unused_result
Date: Fri, 04 Feb 2011 10:41:32 +0200	[thread overview]
Message-ID: <83bp2sb39f.fsf@gnu.org> (raw)
In-Reply-To: <4D4B20C5.1070100@cs.ucla.edu>

> Date: Thu, 03 Feb 2011 13:40:21 -0800
> From: Paul Eggert <eggert@cs.ucla.edu>
> CC: Emacs-Devel devel <emacs-devel@gnu.org>, Eli Zaretskii <eliz@gnu.org>
> 
> On 02/03/11 12:42, Chad Brown wrote:
> 
> > ..and it broke the W32 and nextstep builds (at least) again.
> 
> Sorry, I forgot to add the new file lib/ignore-value.h.
> That should be fixed now.
> 
> On 02/03/11 13:16, Eli Zaretskii wrote:
> 
> > And is butt-ugly, IMO.
> 
> I don't like ignore-value either.  I'd rather that we simply
> tell GCC never to generate those bogus warnings anywhere.
> However, as I understand it, that's not so easily done.

The -Wno-unused-result compiler options looks easy to me, and is IMO
cleaner than using ignore-value.h.  Heck, even the corresponding
pragma in the affected source files looks cleaner.

The only advantage of ignore-value.h is that it will work with
compilers other than GCC (if some of them also insist on this
warning).



  reply	other threads:[~2011-02-04  8:41 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-03 14:57 attribute warn_unused_result Eli Zaretskii
2011-02-03 18:53 ` Stefan Monnier
2011-02-03 19:33   ` Paul Eggert
2011-02-03 20:42     ` Chad Brown
2011-02-03 21:30       ` Eli Zaretskii
2011-02-03 21:58         ` Paul Eggert
2011-02-04  0:17           ` Lennart Borgman
2011-02-04  8:18           ` Eli Zaretskii
2011-02-05 16:30             ` Chong Yidong
2011-02-03 21:40       ` Paul Eggert
2011-02-04  8:41         ` Eli Zaretskii [this message]
2011-02-04  8:51           ` Paul Eggert
2011-02-04 21:05         ` Stefan Monnier
2011-02-05  8:50           ` Eli Zaretskii
2011-02-03 21:47       ` Lennart Borgman
2011-02-04 21:08         ` Stefan Monnier
2011-02-04 21:15           ` Lennart Borgman
2011-02-05  9:03             ` Eli Zaretskii
2011-02-05  8:59           ` Eli Zaretskii
2011-02-03 22:08       ` Andy Moreton
2011-02-03 23:00         ` Paul Eggert
2011-02-03 21:16     ` Eli Zaretskii
2011-02-03 21:14   ` Eli Zaretskii
2011-02-04  0:57     ` Paul Eggert
2011-02-04  8:29       ` Eli Zaretskii
2011-02-04 15:50         ` Tom Tromey
2011-02-04 16:38           ` Eli Zaretskii
2011-02-04 17:12             ` Tom Tromey
2011-02-05  0:11             ` Paul Eggert
2011-02-05  9:18               ` Eli Zaretskii
     [not found]               ` <yyxvd0yxwv1.fsf@fencepost.gnu.org>
2011-02-06  1:34                 ` Paul Eggert
2011-02-06  4:07                   ` Eli Zaretskii
2011-02-06  7:04                     ` Paul Eggert
2011-02-06 10:21                       ` Eli Zaretskii
2011-02-06 18:58                         ` Paul Eggert
2011-02-06 19:27                           ` Eli Zaretskii
2011-02-06 20:11                             ` Paul Eggert
2011-02-06 21:26                               ` Eli Zaretskii
2011-02-04 21:14         ` Stefan Monnier
2011-02-05  8:57           ` Eli Zaretskii
2011-02-05 16:01             ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83bp2sb39f.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    --cc=yandros@MIT.EDU \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).