From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH v2] POSIX ACL support Date: Tue, 04 Dec 2012 22:42:03 +0200 Message-ID: <83boe9r1lw.fsf@gnu.org> References: <87zk1wxlto.fsf@silenus.orebokech.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1354653732 27920 80.91.229.3 (4 Dec 2012 20:42:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 4 Dec 2012 20:42:12 +0000 (UTC) Cc: emacs-devel@gnu.org To: Romain Francoise Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 04 21:42:25 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TfzJw-00072A-09 for ged-emacs-devel@m.gmane.org; Tue, 04 Dec 2012 21:42:24 +0100 Original-Received: from localhost ([::1]:45345 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfzJj-0004jT-VC for ged-emacs-devel@m.gmane.org; Tue, 04 Dec 2012 15:42:11 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:52333) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfzJg-0004iU-OY for emacs-devel@gnu.org; Tue, 04 Dec 2012 15:42:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TfzJf-0007Xr-65 for emacs-devel@gnu.org; Tue, 04 Dec 2012 15:42:08 -0500 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:60809) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfzJe-0007XI-V6 for emacs-devel@gnu.org; Tue, 04 Dec 2012 15:42:07 -0500 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MEI00400XC1K900@a-mtaout23.012.net.il> for emacs-devel@gnu.org; Tue, 04 Dec 2012 22:42:05 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MEI00439XI4JM20@a-mtaout23.012.net.il>; Tue, 04 Dec 2012 22:42:05 +0200 (IST) In-reply-to: <87zk1wxlto.fsf@silenus.orebokech.com> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.175 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:155260 Archived-At: > From: Romain Francoise > Date: Sun, 02 Dec 2012 21:04:19 +0100 > > This is another iteration with the following changes: > - C-level functions renamed to `file-acl' and `set-file-acl' in hope that > they can be used with non-POSIX ACL implementations; conversely the > parts of the implementation that are POSIX ACL specific are now inside > HAVE_POSIX_ACL > - the additional argument to `copy-file' has been dropped, the existing > argument `preserve-selinux-context' has been turned into a more generic > `preserve-extended-attributes' argument which does both SELinux and ACL > - new functions `file-extended-attributes' and `set-file-extended-attributes' > have been added to make the implementation cleaner in files.el, handling > both SELinux context and ACL entries (do they need to be documented in > the Elisp manual?) > > Tested again on GNU/Linux with libacl, and FreeBSD. > > Comments welcome! Thanks. > +@cindex ACL entries Suggest an additional entry "@cindex access control list" here. > + If Emacs has been compiled with ACL support, you can use the function > +@code{file-acl} to retrieve a file's ACL entries. The format is > +platform-specific; on GNU/Linux and BSD, Emacs uses the POSIX ACL > +interface. For the function @code{set-file-acl}, see @ref{Changing > +Files}. We don't mention "ACL" or explain it anywhere else in the manual. So this acronym should be explained here, and its first use should use @dfn, as we do with any new terminology. > +DEFUN ("file-acl", Ffile_acl, Sfile_acl, 1, 1, 0, > + doc: /* Return ACL entries of file named FILENAME, as a string. > +Return nil if file does not exist or is not accessible, or if Emacs was > +not compiled with ACL support. */) The last sentence of the doc string is inaccurate, because remote files are supported even if Emacs was not built with ACL support. > +DEFUN ("set-file-acl", Fset_file_acl, Sset_file_acl, > + 2, 2, 0, > + doc: /* Set ACL of file named FILENAME to ACL-STRING. > +ACL-STRING should contain the textual representation of the ACL > +entries in a format suitable for the platform. > + > +This function does nothing if Emacs was not compiled with ACL > +support. */) Same here.