From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: bug#9782: 24.0.90; move-to-window-line not taking header line into account
Date: Mon, 06 May 2013 19:38:26 +0300 [thread overview]
Message-ID: <83bo8of4hp.fsf@gnu.org> (raw)
In-Reply-To: <518725C3.10107@yandex.ru>
> Date: Mon, 06 May 2013 07:38:43 +0400
> From: Dmitry Gutov <dgutov@yandex.ru>
> CC: emacs-devel@gnu.org
>
> >> But it's a seemingly reasonable piece of code, it worked, and your
> >> change made it break in some peculiar special case important to some
> >> users.
> >
> > That's not true. It was not a peculiar special case. The function did
> > not behave according to its contract, and my change fixed that.
>
> Comparing the descriptions of `move-to-window-line' and
> `posn-actual-col-row', it doesn't seem obvious that one considers the
> header line part of the window, and another doesn't. The words "row" and
> "line" are often synonymous in English.
Perhaps we need to improve the documentation of the posn-* family of
functions, then. It is important to keep in mind that this family
serves mainly the mouse events, so its coordinate system is
window-relative. The use of columns and rows there is just to measure
in character units, rather than in pixels. But it is still
window-relative and agnostic to the header line, like the mouse is.
> `company-pseudo-tooltip-show-at-point' passes the current row and column
> to `company-pseudo-tooltip-show', which collects are required lines and
> prepares the `before-string' for the overlay.
>
> These two would be the easiest to convert to direct point manipulation,
> except for the detail that they calculate, use and store the beginning
> column in the overlay property, for use later.
>
> `company--pseudo-tooltip-height' calculates the appropriate rectangle
> height, based on the current row and the inner height of the window.
>
> `company--electric-do' (somewhat unrelated) calls `recenter' using the
> value returned by `posn-actual-col-row'.
>
> `company-select-mouse' and `company--inside-tooltip-p' handle mouse
> interaction with the rectangle, comparing the coordinates of the mouse
> click with the coordinates and dimensions of the rectangle (some of them
> saved previously; the current row is again retrieved using
> `posn-actual-col-row').
I don't see company--inside-tooltip-p anywhere in today's ELPA company
package, but anyway, why do you need to use coordinates to determine
whether the mouse clicked on the pseudo-tooltip? The pseudo-tooltip
is a display or overlay string, right? So the OBJECT part of the
event's POSITION member will tell you whether you clicked on the
string or not: if it's nil, the click is on some buffer text, but if
it's the display string, the click was on that string.
> 1) Using `move-to-window-line', `vertical-motion' and a counter.
Actually, I think you want something like
(count-screen-lines (window-start) (point))
And for the mouse, see the suggestion above.
next prev parent reply other threads:[~2013-05-06 16:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m2hb361p8e.fsf@ibookg4-c2.pc.gwdg.de>
[not found] ` <E1RGADD-0008JI-Ht@fencepost.gnu.org>
[not found] ` <m28voi1iqe.fsf@ibookg4-c2.pc.gwdg.de>
[not found] ` <83mxcyuw60.fsf@gnu.org>
2013-05-04 21:12 ` bug#9782: 24.0.90; move-to-window-line not taking header line into account Dmitry Gutov
2013-05-05 2:47 ` Eli Zaretskii
2013-05-05 2:59 ` Dmitry Gutov
2013-05-05 15:53 ` Eli Zaretskii
2013-05-06 3:38 ` Dmitry Gutov
2013-05-06 16:38 ` Eli Zaretskii [this message]
2013-05-07 1:26 ` Dmitry Gutov
2013-05-07 2:54 ` Eli Zaretskii
2013-05-07 7:41 ` Dmitry Gutov
2013-05-07 16:50 ` Eli Zaretskii
2013-05-07 17:19 ` Dmitry Gutov
2014-08-15 23:33 ` Dmitry Gutov
2014-08-16 8:03 ` Eli Zaretskii
2014-08-16 8:27 ` Dmitry Gutov
2014-08-16 11:12 ` Eli Zaretskii
2014-08-19 4:51 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bo8of4hp.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).