unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: sean.sieger@gmail.com
Cc: emacs-devel@gnu.org
Subject: Re: windows build failure
Date: Sat, 12 Oct 2013 16:31:09 +0300	[thread overview]
Message-ID: <83bo2ur4yq.fsf@gnu.org> (raw)
In-Reply-To: <8338ozl7cd.fsf@gnu.org>

> Date: Fri, 20 Sep 2013 20:40:34 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: emacs-devel@gnu.org
> 
> > From: Sean Sieger <sean.sieger@gmail.com>
> > Date: Fri, 20 Sep 2013 12:34:28 -0400
> > 
> >     Does the below work as expected?
> > 
> >       emacs -Q c*.c
> > 
> >     If you do this from the src directory, you should end up with visiting
> >     the 14 C files that match the wildcard in the Emacs's src directory.
> >     What do you get in Emacs linked with the new MinGW runtime?
> > 
> > Wait, wait, wait ...
> > 
> > MinGW-Shell:
> > 
> > Sean@blah /c/trunk/src/
> > $ emacs -Q c*.c
> > 
> > ... I get the correct result.
> 
> In the MSYS Bash, the shell does the wildcard expansion, that's why
> you get correct results.
> 
> > Command Prompt:
> > 
> > c:\trunk\src>emacs -Q c*.c
> > 
> > ... nope, visits the non-existent, `c*.c'.
> 
> Right, as I expected.
> 
> Here's why: MinGW runtime v4.x changed the layout of 'struct dirent',
> the structure returned by 'readdir', in an incompatible way.  Where
> previously we had
> [...]
> What happens in Emacs as result is that the startup code calls the
> Emacs implementation of 'readdir', which uses an incompatible 'struct
> dirent', and the result is that globbing of wildcards is broken.

I tried to fix this problem in trunk revision 114637.  If you (or
someone else who would like to move to the new MinGW runtime) have
time, please re-test with v4.0 of the MinGW runtime.

Please also try the various time-related functions, such as
decode-time, encode-time, format-time-string, and
current-time-string.  This is because MinGW32 runtime 4.0 also moved
to using a 64-bit time_t type by default, which according to my
testing screws up Emacs, especially if it was built on Windows 7 and
then run on XP.  So for now, I forced the MinGW32 headers to use a
32-bit time_t type.  This needs to be thoroughly tested, though.

Thanks.

> At the time, I tried to convince the MinGW developers not to do this,
> here:
> 
>   http://sourceforge.net/mailarchive/message.php?msg_id=29278605
>   http://sourceforge.net/mailarchive/message.php?msg_id=30712991
>   http://sourceforge.net/mailarchive/message.php?msg_id=30715094
>   http://sourceforge.net/mailarchive/message.php?msg_id=30854291
> 
> Evidently, I failed completely to convince them, as the incompatible
> runtime went to print regardless, and the problems will now begin
> unfolding before our eyes...

Well, it turns out the MinGW developers might be listening after all,
at least to some of the arguments: I'm promised that the next release
of the runtime will not call opendir/readdir from the startup code.
We shall see...



  reply	other threads:[~2013-10-12 13:31 UTC|newest]

Thread overview: 99+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-17 21:45 windows build failure Sean Sieger
2013-09-18  6:42 ` Eli Zaretskii
2013-09-18  6:56   ` Dani Moncayo
2013-09-18  7:23     ` Eli Zaretskii
2013-09-18 12:37       ` Sean Sieger
2013-09-18 12:44         ` Eli Zaretskii
     [not found]   ` <CADWZ7fL5iWhAWqrc8RqipO3Zgaz=AygHPUhhTNG97zTVaxpE3g@mail.gmail.com>
2013-09-18 12:46     ` Eli Zaretskii
2013-09-18 13:08       ` Sean Sieger
2013-09-18 13:18         ` Eli Zaretskii
2013-09-18 13:25           ` Sean Sieger
2013-09-18 14:48             ` Eli Zaretskii
2013-09-18 15:15               ` Sean Sieger
2013-09-18 15:28                 ` Eli Zaretskii
2013-09-18 15:38                   ` Sean Sieger
2013-09-19 14:14               ` Sean Sieger
2013-09-19 14:24                 ` Eli Zaretskii
2013-09-19 17:33                   ` Sean Sieger
2013-09-19 18:46                     ` Eli Zaretskii
2013-09-19 20:25                       ` Sean Sieger
2013-09-20  7:28                         ` Eli Zaretskii
2013-09-20 14:24                           ` Sean Sieger
2013-09-20 15:16                             ` Eli Zaretskii
2013-09-20 16:23                               ` Sean Sieger
2013-09-20 16:34                               ` Sean Sieger
2013-09-20 17:40                                 ` Eli Zaretskii
2013-10-12 13:31                                   ` Eli Zaretskii [this message]
2013-10-12 15:55                                     ` Paul Eggert
2013-10-12 16:49                                       ` Eli Zaretskii
2013-10-12 19:13                                         ` Paul Eggert
2013-10-12 20:03                                           ` Eli Zaretskii
2013-10-12 21:45                                             ` Paul Eggert
2013-10-12 19:31                                     ` Sean Sieger
2013-10-14 12:41                                     ` Sean Sieger
2013-10-14 16:25                                       ` Eli Zaretskii
2013-10-14 17:31                                         ` Sean Sieger
2013-10-14 18:02                                     ` Sean Sieger
2013-10-14 18:10                                       ` Eli Zaretskii
2013-10-14 19:06                                         ` Sean Sieger
2013-10-14 19:13                                           ` Eli Zaretskii
2013-10-14 19:24                                             ` Sean Sieger
  -- strict thread matches above, loose matches on Subject: below --
2013-05-26 20:29 Sean Sieger
2013-05-27 16:36 ` Eli Zaretskii
2013-05-27 18:07   ` Óscar Fuentes
2013-05-27 19:10     ` Eli Zaretskii
2013-05-27 19:56       ` Óscar Fuentes
2013-05-28 18:19   ` Sean Sieger
2013-05-28 19:07     ` Eli Zaretskii
2013-05-29 13:15       ` rzl24ozi
2013-05-29 15:21         ` Eli Zaretskii
2013-05-29 15:50           ` Óscar Fuentes
2013-05-29 17:17             ` Eli Zaretskii
2013-05-29 17:02           ` Paul Eggert
2013-05-29 17:20             ` Eli Zaretskii
2013-05-29 18:55               ` Paul Eggert
2013-05-29 20:28                 ` Eli Zaretskii
2013-05-29 21:27                   ` Paul Eggert
2013-05-30  2:46                     ` Eli Zaretskii
2013-05-29 23:35           ` rzl24ozi
2013-05-30 18:03             ` Eli Zaretskii
2013-05-30 19:38               ` rzl24ozi
2013-05-31  8:50                 ` Eli Zaretskii
2013-05-29 16:06   ` cg
2013-05-29 17:21     ` Eli Zaretskii
2012-07-29 16:40 Windows " Dani Moncayo
2012-07-29 16:49 ` Dani Moncayo
2011-02-21 19:37 windows " Sean Sieger
2011-02-21 19:40 ` Sean Sieger
2011-02-21 19:46 ` Christoph
2011-02-21 19:48 ` Paul Eggert
2011-02-21 20:21   ` Eli Zaretskii
2011-02-21 20:29     ` Lennart Borgman
2011-02-21 22:50     ` Sean Sieger
2011-02-21 20:37   ` Eli Zaretskii
2011-02-22  2:09     ` Paul Eggert
2011-02-22  8:57       ` Eli Zaretskii
2011-02-22  9:40         ` Paul Eggert
2011-02-22 10:49           ` Eli Zaretskii
2011-02-22 21:44             ` Paul Eggert
2011-02-23  9:47               ` Eli Zaretskii
2011-02-23 10:32                 ` Eli Zaretskii
2011-02-25 21:28                 ` Paul Eggert
2011-02-14 16:47 Sean Sieger
2011-02-14 16:54 ` Tom Tromey
2011-02-14 17:17   ` Eli Zaretskii
2011-02-14 17:20     ` Sean Sieger
2011-02-14 17:49     ` Eli Zaretskii
2011-02-14 18:02       ` Tom Tromey
2011-02-14 20:43       ` Sean Sieger
2011-01-03 17:57 Sean Sieger
2011-01-03 19:37 ` Eli Zaretskii
2010-08-02 15:01 Sean Sieger
2010-08-02 15:05 ` Juanma Barranquero
2010-08-02 15:16   ` Sean Sieger
2010-07-19 14:42 Sean Sieger
2010-07-19 15:03 ` Óscar Fuentes
2010-07-19 15:30   ` Juanma Barranquero
2010-07-19 17:45     ` Eli Zaretskii
2010-07-20 18:33       ` Juanma Barranquero
2010-07-19 18:35   ` Sean Sieger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83bo2ur4yq.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=sean.sieger@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).