From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Redisplay problems? Date: Thu, 20 Mar 2014 18:19:12 +0200 Message-ID: <83bnx09727.fsf@gnu.org> References: <87ppljg4ti.fsf@kanru-mozilla.corp.tpe1.mozilla.com> <5329C53B.3030008@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=shift_jis Content-Transfer-Encoding: QUOTED-PRINTABLE X-Trace: ger.gmane.org 1395332347 16851 80.91.229.3 (20 Mar 2014 16:19:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 20 Mar 2014 16:19:07 +0000 (UTC) Cc: rudalics@gmx.at, christian@defun.dk, kanru@kanru.info, cloos@jhcloos.com, emacs-devel@gnu.org To: Stefan Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 20 17:19:16 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WQfgX-0001Hn-HV for ged-emacs-devel@m.gmane.org; Thu, 20 Mar 2014 17:19:13 +0100 Original-Received: from localhost ([::1]:48062 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQfgX-0005Xa-40 for ged-emacs-devel@m.gmane.org; Thu, 20 Mar 2014 12:19:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41930) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQfgO-0005M4-F9 for emacs-devel@gnu.org; Thu, 20 Mar 2014 12:19:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQfgK-0004Ju-8E for emacs-devel@gnu.org; Thu, 20 Mar 2014 12:19:04 -0400 Original-Received: from mtaout26.012.net.il ([80.179.55.182]:55003) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQfgJ-0004Jj-WC for emacs-devel@gnu.org; Thu, 20 Mar 2014 12:19:00 -0400 Original-Received: from conversion-daemon.mtaout26.012.net.il by mtaout26.012.net.il (HyperSendmail v2007.08) id <0N2Q00A00SVGN000@mtaout26.012.net.il> for emacs-devel@gnu.org; Thu, 20 Mar 2014 18:18:09 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout26.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N2Q00BYBTA9US00@mtaout26.012.net.il>; Thu, 20 Mar 2014 18:18:09 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:170627 Archived-At: > From: Stefan > Date: Thu, 20 Mar 2014 00:46:13 -0400 > Cc: Christian Lynbech , James Cloos , > =09Kan-Ru Chen (=92=C2=8A=A4=94@) , > =09emacs-devel@gnu.org >=20 > > Does the attached patch fix it? >=20 > The patch below seems to fix the problem (at least the test case). > Can someone confirm that it's a good idea? >=20 > > If so, we probably need a better way to avoid > > > > If we where iconified, we should not set garbaged, > > because that stops redrawing on Expose events. This= looks > > bad if we are called from a recursive event loop > > (x_dispatch_event), for example when a dialog is up. >=20 > I think my patch indeed fixes this problem by distinguishing betwee= n > f->garbaged (which presumably stops redrawing in Expose, tho I don'= t > offhand see where that happens) and frame_garbaged (which is needed= to > get the next redisplay to be properly triggered and performed). If you are worried about doing too much when a frame is deiconified, why do you want a hammer such as frame_garbaged? This sounds like a contradiction to me.