Re: Redisplay problems?

[Eli Zaretskii <eliz@gnu.org>]

> From: Stefan <monnier@iro.umontreal.ca>
> Date: Thu, 20 Mar 2014 00:46:13 -0400
> Cc: Christian Lynbech <christian@defun.dk>, James Cloos <cloos@jhcloos.com>,
> 	Kan-Ru Chen (陳侃如) <kanru@kanru.info>,
> 	emacs-devel@gnu.org
> 
> > Does the attached patch fix it?
> 
> The patch below seems to fix the problem (at least the test case).
> Can someone confirm that it's a good idea?
> 
> > If so, we probably need a better way to avoid
> >
> >              If we where iconified, we should not set garbaged,
> >              because that stops redrawing on Expose events.  This looks
> >              bad if we are called from a recursive event loop
> >              (x_dispatch_event), for example when a dialog is up.
> 
> I think my patch indeed fixes this problem by distinguishing between
> f->garbaged (which presumably stops redrawing in Expose, tho I don't
> offhand see where that happens) and frame_garbaged (which is needed to
> get the next redisplay to be properly triggered and performed).

If you are worried about doing too much when a frame is deiconified,
why do you want a hammer such as frame_garbaged?  This sounds like a
contradiction to me.