From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: MS-Windows tester wanted for trunk Date: Tue, 16 Sep 2014 18:58:50 +0300 Message-ID: <83bnqf4kw5.fsf@gnu.org> References: <5417F9B8.9020503@yandex.ru> <83r3zb4oyh.fsf@gnu.org> <5418562C.9040501@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1410883165 29538 80.91.229.3 (16 Sep 2014 15:59:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 16 Sep 2014 15:59:25 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Antipov , Ken Brown Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 16 17:59:18 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XTv9r-0003Tw-L7 for ged-emacs-devel@m.gmane.org; Tue, 16 Sep 2014 17:59:11 +0200 Original-Received: from localhost ([::1]:38834 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTv9r-0006CY-Cf for ged-emacs-devel@m.gmane.org; Tue, 16 Sep 2014 11:59:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48641) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTv9j-0006Bp-89 for emacs-devel@gnu.org; Tue, 16 Sep 2014 11:59:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTv9d-0008Bf-Se for emacs-devel@gnu.org; Tue, 16 Sep 2014 11:59:03 -0400 Original-Received: from mtaout28.012.net.il ([80.179.55.184]:55355) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTv9d-0008BL-Kp for emacs-devel@gnu.org; Tue, 16 Sep 2014 11:58:57 -0400 Original-Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NC000J0047DQG00@mtaout28.012.net.il> for emacs-devel@gnu.org; Tue, 16 Sep 2014 18:57:47 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NC000BNM4CAO380@mtaout28.012.net.il>; Tue, 16 Sep 2014 18:57:47 +0300 (IDT) In-reply-to: <5418562C.9040501@yandex.ru> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.184 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:174374 Archived-At: > Date: Tue, 16 Sep 2014 19:24:28 +0400 > From: Dmitry Antipov > CC: emacs-devel@gnu.org > > On 09/16/2014 06:31 PM, Eli Zaretskii wrote: > > > So the conclusion is that, at least for 32-bit Windows builds, the > > alignment of union Aligned_Cons is not enough to produce the effect > > you want, and additional measures are necessary. > > > > I don't expect this to be a problem in 64-bit Windows builds, because > > there Windows does enforce 16-byte alignment of the stack. But, as I > > already said, I didn't test that. > > Do we have the same issue with alloca? No, not as long as our functions are called only by our functions, not as callbacks from Windows DLLs. > If not, whether it will be simpler to define scoped_cons to > local_cons for 32-bit Windows builds? You'll have to educate me about the difference, sorry. I can try whatever you want. > > This could be an issue in other x86 32-bit builds (probably not on > > GNU/Linux, though, and not if GCC is the compiler), because AFAIK the > > x86 ABI specifies a 4-byte stack alignment. > > Hm...I'll try 32-bit builds with clang and icc. BTW, both of them mimics > GCC quite well, so I will be very surprised with an issues here. I think the 32-bit Cygwin-w32 build might also be affected, as it uses the same w32font.c code. Ken, can you try that, please?