From: Eli Zaretskii <eliz@gnu.org>
To: bruce.connor.am@gmail.com
Cc: dak@gnu.org, emacs-devel@gnu.org
Subject: Re: Should we have a commit size guideline? (was: builds are getting slower?)
Date: Tue, 15 Dec 2015 18:16:36 +0200 [thread overview]
Message-ID: <83bn9r3cwr.fsf@gnu.org> (raw)
In-Reply-To: <CAAdUY-K7n-FswpccVae=Zp_VJn9bo8Gz+5WHi3A5WayUbBNCtA@mail.gmail.com> (message from Artur Malabarba on Tue, 15 Dec 2015 13:48:28 +0000)
> Date: Tue, 15 Dec 2015 13:48:28 +0000
> From: Artur Malabarba <bruce.connor.am@gmail.com>
> Cc: emacs-devel <emacs-devel@gnu.org>
>
> > This is a very, very large commit. It should have been split into
> > multiple commits addressing separate issues.
>
> When commiting changes, I usually group them into the smallest
> possible commits while still leaving everything in a consistent state
> (i.e., not defining a function that's only used in later commits, not
> changing a function without making the necessary changes in other
> places that call this function). I find that this helps with both
> git-bisect and git-revert.
>
> If we have a different policy (maybe we should) I'm happy to adhere.
I generally prefer to see the commits in one go, rather than split.
It makes it easier for me to review it.
next prev parent reply other threads:[~2015-12-15 16:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-15 13:48 Should we have a commit size guideline? (was: builds are getting slower?) Artur Malabarba
2015-12-15 14:23 ` Should we have a commit size guideline? David Kastrup
2015-12-16 11:12 ` Artur Malabarba
2015-12-15 16:16 ` Eli Zaretskii [this message]
2015-12-15 17:56 ` John Wiegley
2015-12-16 0:13 ` Paul Eggert
2015-12-16 0:23 ` Dmitry Gutov
2015-12-16 1:00 ` Paul Eggert
2015-12-16 1:19 ` indent-tabs-mode setting in Emacs's dir-locals.el Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bn9r3cwr.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=bruce.connor.am@gmail.com \
--cc=dak@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).