From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: tags-loop-continue Date: Sun, 10 Jan 2016 17:54:01 +0200 Message-ID: <83bn8tmnvq.fsf@gnu.org> References: <83wprimto9.fsf@gnu.org> <56916C10.6050004@yandex.ru> <83oacumqmj.fsf@gnu.org> <56917246.1010800@yandex.ru> <5691795E.9010008@yandex.ru> <83lh7ym725.fsf@gnu.org> <5691D768.3020908@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1452441252 16940 80.91.229.3 (10 Jan 2016 15:54:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 10 Jan 2016 15:54:12 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 10 16:54:07 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aIIJi-00017s-Bx for ged-emacs-devel@m.gmane.org; Sun, 10 Jan 2016 16:54:06 +0100 Original-Received: from localhost ([::1]:47461 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aIIJh-00060K-F2 for ged-emacs-devel@m.gmane.org; Sun, 10 Jan 2016 10:54:05 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58021) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aIIJe-000609-D4 for emacs-devel@gnu.org; Sun, 10 Jan 2016 10:54:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aIIJZ-0006HK-KU for emacs-devel@gnu.org; Sun, 10 Jan 2016 10:54:02 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44186) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aIIJZ-0006HG-Ga; Sun, 10 Jan 2016 10:53:57 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3106 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aIIJY-0007Kc-T8; Sun, 10 Jan 2016 10:53:57 -0500 In-reply-to: <5691D768.3020908@yandex.ru> (message from Dmitry Gutov on Sun, 10 Jan 2016 07:00:40 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:197969 Archived-At: > Cc: emacs-devel@gnu.org > From: Dmitry Gutov > Date: Sun, 10 Jan 2016 07:00:40 +0300 > > tags-loop-continue is also used by Dired, see 'A' and 'Q' in > "Operating on Files". > > I'm fairly sure these commands are more obscure, and used considerably less frequently than find-tag, or xref-find-definitions that's poised to replace it. I think you've just heard from someone who evidently does use them: http://lists.gnu.org/archive/html/emacs-devel/2016-01/msg00627.html > C-, is too nice a key binding to spend on them. You mean 'M-,', I presume. > If we want to retain some global binding for tags-loop-continue, let's move it to C-*. I'm afraid it won't go down well with the users of those commands. Besides, 'C-*' is not available on TTYs. > Look at this from the user's POV: these two commands, as well as > tags-search and tags-query-replace, are still available, so users will > expect to be able to continue them as they did before. How can we > explain to them that the keybinding for that command changed? > > In the NEWS file, and in the manual? I asked "how", not "where". This command (tags-loop-continue) existed before and had a keybinding; it will also exist in Emacs 25.1 -- how do we explain that it now has a different keybinding, or no keybinding at all? What good reasons do we give for such a backward-incompatible change in a veteran command? > Other than that, what technical solution is used to keep the command > and its keybinding available is unimportant, I think. > > It doesn't seem like tags-search uses any special keymap during its execution. I didn't talk about tags-search, I'm talking only about tags-loop-continue. I think it should remain an interactive command (so it could be easily rebound and invoked by name), and it should be bound to 'M-,' as it was before. We will need to find a new binding for xref-query-replace, which is unfortunate, but I don't see a better way forward.