From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] fix conv_lisp_to_sockaddr for AF_INET6 addresses Date: Wed, 10 Feb 2016 22:31:05 +0200 Message-ID: <83bn7o9uk6.fsf@gnu.org> References: <87egco56s6.fsf@gnus.org> <83io1zri30.fsf@gnu.org> <87r3gnhmu1.fsf@gnus.org> <87mvrbhmkm.fsf@gnus.org> <83h9hjqgk7.fsf@gnu.org> <87a8nalrlp.fsf@gnus.org> <83mvr9bstb.fsf@gnu.org> <877fid8ou5.fsf@gnus.org> <83d1s49vm6.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1455136288 31438 80.91.229.3 (10 Feb 2016 20:31:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 10 Feb 2016 20:31:28 +0000 (UTC) Cc: emacs-devel@gnu.org To: larsi@gnus.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 10 21:31:24 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aTbQ2-0003Fw-G8 for ged-emacs-devel@m.gmane.org; Wed, 10 Feb 2016 21:31:22 +0100 Original-Received: from localhost ([::1]:42874 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTbQ1-000537-FO for ged-emacs-devel@m.gmane.org; Wed, 10 Feb 2016 15:31:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52750) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTbPy-00052v-BL for emacs-devel@gnu.org; Wed, 10 Feb 2016 15:31:19 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTbPv-0002kS-JE for emacs-devel@gnu.org; Wed, 10 Feb 2016 15:31:18 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42317) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTbPv-0002k0-Fo; Wed, 10 Feb 2016 15:31:15 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3226 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aTbPu-000867-Ob; Wed, 10 Feb 2016 15:31:15 -0500 In-reply-to: <83d1s49vm6.fsf@gnu.org> (message from Eli Zaretskii on Wed, 10 Feb 2016 22:08:17 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:199724 Archived-At: > Date: Wed, 10 Feb 2016 22:08:17 +0200 > From: Eli Zaretskii > Cc: emacs-devel@gnu.org > > > That's very strange. If I remove connect-to-tls-ipv6-nowait from the > > file and say "make lisp/net/network-stream-tests" then all the remaining > > tests pass. > > Here, echo-server-nowait fails if I do that. > > > And echo-server-nowait doesn't talk to the same port at the TLS tests, > > so that's doubly weird. > > Yep. Any ideas besides some weird timing problem? > > > > However, when connect-to-tls-ipv6-nowait is left to run (and fail), > > > then echo-server-nowait succeeds. > > > > When it fails, is the gnutls-serv process still running? > > By "it" do you mean connect-to-tls-ipv6-nowait? If so, AFAICT > gnutls-serv exits immediately when the failure is reported. It's indeed some weird problem with timing or maybe with events in batch mode. The patch below (which also skips the IPv6 test on MS-Windows) fixes it. Do you see any problems with it? diff --git a/test/lisp/net/network-stream-tests.el b/test/lisp/net/network-stream-tests.el index 92c5370..d3f229e 100644 --- a/test/lisp/net/network-stream-tests.el +++ b/test/lisp/net/network-stream-tests.el @@ -192,6 +192,7 @@ make-tls-server (setq status (gnutls-peer-status proc)) (should (consp status)) (delete-process proc) + (sleep-for 0.1) (let ((issuer (plist-get (plist-get status :certificate) :issuer))) (should (stringp issuer)) (setq issuer (split-string issuer ",")) @@ -200,6 +201,7 @@ make-tls-server (ert-deftest connect-to-tls-ipv6-nowait () (skip-unless (executable-find "gnutls-serv")) (skip-unless (gnutls-available-p)) + (skip-unless (not (eq system-type 'windows-nt))) (let ((server (make-tls-server)) (times 0) proc status) @@ -226,6 +228,7 @@ make-tls-server (setq status (gnutls-peer-status proc)) (should (consp status)) (delete-process proc) + (sleep-for 0.1) (let ((issuer (plist-get (plist-get status :certificate) :issuer))) (should (stringp issuer)) (setq issuer (split-string issuer ","))